From: David Bremner <david@tethera.net>
To: Uli Scholler <uli@scholler.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: wrap current search in parens when filtering
Date: Sat, 05 Sep 2015 23:35:56 -0300 [thread overview]
Message-ID: <87oahgi8ab.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <87io7rxj6k.fsf@tardis.scholler.priv>
Some pretty fussy comments follow. Probably I could have fixed these in
the time it took to write this message ;).
Uli Scholler <uli@scholler.net> writes:
> + (let ((grouped-query (notmuch-maybe-group-query-string query))
> + (grouped-search-query (notmuch-maybe-group-query-string notmuch-search-query-string)))
- I didn't find it very obvious which of these introduced variables was
which. I thought maybe "grouped-original-query" for the second
one. It's pretty subjective though, so your call.
- The lines get pretty long here. We try to keep code to 80 columns.
- Your revised patch isn't in quite the right format for git am;
the actual commit message get's lost. The unintuitive trick is to add
commentary in the patch after the ---
> + (notmuch-search (if (string= grouped-search-query "*")
> grouped-query
> - (concat notmuch-search-query-string " and " grouped-query)) notmuch-search-oldest-first)))
> + (concat grouped-search-query " and " grouped-query)) notmuch-search-oldest-first)))
next prev parent reply other threads:[~2015-09-06 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 21:57 [PATCH] emacs: wrap current search in parens when filtering Uli Scholler
2015-09-03 7:32 ` Tomi Ollila
2015-09-03 21:54 ` [PATCH v2] " Uli Scholler
2015-09-06 2:35 ` David Bremner [this message]
2015-09-06 9:19 ` Tomi Ollila
2015-09-06 21:29 ` [PATCH v3] " Uli Scholler
2015-09-07 6:14 ` Tomi Ollila
2015-09-07 12:50 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oahgi8ab.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=uli@scholler.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).