From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 20DC16DE0FFA
 for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 04:52:10 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.551
X-Spam-Level: 
X-Spam-Status: No, score=-0.551 tagged_above=-999 required=5
 tests=[RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id kWsQ23xifcFk for <notmuch@notmuchmail.org>;
 Mon, 23 Nov 2015 04:52:07 -0800 (PST)
X-Greylist: delayed 357 seconds by postgrey-1.35 at arlo;
 Mon, 23 Nov 2015 04:52:07 PST
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 509116DE0943
 for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 04:52:07 -0800 (PST)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
 (envelope-from <david@tethera.net>)
 id 1a0qbD-0000VA-6G; Mon, 23 Nov 2015 07:52:03 -0500
Received: (nullmailer pid 6638 invoked by uid 1000);
 Mon, 23 Nov 2015 12:52:02 -0000
From: David Bremner <david@tethera.net>
To: Steven Allen <steven@stebalien.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] forbid atomic transactions on writable, upgradable
 databases
In-Reply-To: <1445808639-5378-1-git-send-email-steven@stebalien.com>
References: <1445808639-5378-1-git-send-email-steven@stebalien.com>
User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Mon, 23 Nov 2015 08:52:02 -0400
Message-ID: <87oaek5159.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Nov 2015 12:52:10 -0000

Steven Allen <steven@stebalien.com> writes:

> 1. There is no reason to call `begin_atomic` unless you intend to to
>    write to the database and anyone intending to write to the database
>    should upgrade it first.
> 2. This means that nothing inside an atomic transaction can ever fail
>    with NOTMUCH_STATUS_UPGRADE_REQUIRED.

Applied to master

d