From: David Bremner <david@tethera.net>
To: Patrick Totzke <patricktotzke@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] use notmuch_database_open_verbose
Date: Sat, 12 Mar 2016 12:33:50 -0400 [thread overview]
Message-ID: <87oaaj64gh.fsf@zancas.localnet> (raw)
In-Reply-To: <87r3ff64sa.fsf@zancas.localnet>
David Bremner <david@tethera.net> writes:
>> - """notmuch_database_open"""
>> - _open = nmlib.notmuch_database_open
>> + """notmuch_database_open_verbose"""
>> + _open = nmlib.notmuch_database_open_verbose
>> _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]
>> _open.restype = c_uint
>
> I expect you probably want to add the new binding, rather than replacing
> the old one. Otherwise updating the bindings will break all bindings
> using scripts.
Oh silly me. That's not actually exposed to the python API, so that's
fine. On the other hand, don't you want to update the argument types and
do something useful (throw an exception?) with the returned message? As
it stands you lose information.
d
next prev parent reply other threads:[~2016-03-12 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 15:17 [PATCH] use notmuch_database_open_verbose Patrick Totzke
2016-03-12 16:26 ` David Bremner
2016-03-12 16:33 ` David Bremner [this message]
2016-03-13 12:03 ` Patrick Totzke
[not found] ` <CAM7JpKmVzZYZ8bpjc5qzWvBedKx4GT-y+EKWS1KQgZJ_LamKNw@mail.gmail.com>
2016-03-13 12:37 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaaj64gh.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=patricktotzke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).