From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E37096DE12D0 for ; Tue, 20 Sep 2016 13:18:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.05 X-Spam-Level: X-Spam-Status: No, score=-0.05 tagged_above=-999 required=5 tests=[AWL=-0.050] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sO17iiDvmpB2 for ; Tue, 20 Sep 2016 13:18:39 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id 5E4796DE12C3 for ; Tue, 20 Sep 2016 13:18:39 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id 60346F98C; Tue, 20 Sep 2016 16:18:34 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 261A120A07; Tue, 20 Sep 2016 15:45:12 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] emacs: postpone/resume support In-Reply-To: <87d1kazlof.fsf@zancas.localnet> References: <1473004582-19396-1-git-send-email-markwalters1009@gmail.com> <1473004582-19396-3-git-send-email-markwalters1009@gmail.com> <87d1kazlof.fsf@zancas.localnet> Date: Tue, 20 Sep 2016 15:45:09 -0400 Message-ID: <87oa3iuzi2.fsf@alice.fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 20:18:41 -0000 --=-=-= Content-Type: text/plain On Sun 2016-09-11 08:05:20 -0400, David Bremner wrote: > Mark Walters writes: > >> This provides preliminary support for postponing and resuming in the >> emacs frontend. On postponing it uses notmuch insert to put the >> message in the notmuch database; resume gets the raw file from notmuch >> and using the emacs function mime-to-mml reconstructs the message >> (including attachments). > > I haven't really reviewed this yet, but I noticed it seems to need some > special handling for signed/encrypted messages. > > I created a test message consisting of the mml tag > > "#secure method=pgpmime mode=sign" > > (added with C-c C-m C-s) and a pdf attachment. > > Saving with C-x C-s created a text/plain part with the #secure tag in > it. When I edited (and sent) the saved draft, it did not sign > anything. This might be related to a bug/undocumented-feature of mml > only parsing #secure tags at the top of the message. So this failure that bremner's reporting appears to happen only when combining the #secure mode with a message with attachments. It doesn't happen when the draft itself is just plaintext and one of the #secure flags is set. And there's no problem if there are attachments without the #secure flag. Bremner, can you confirm this? I also noticed that if you rearrange the text before sending so that the #secure flag is at the top of the message, the structure of the message looks weird -- in particular, there's a double layer of multipart/mixed just within the crypto transformation, instead of a single layer. that said, these patches are really useful to me even in their current form, since most of my draft messages don't deal with both crypto and attachments. Is there some way to get the benefits here without the bug at the intersection? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJX4ZHFXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFREIyRTc0RjU2RkNGMkI2NzI5N0I3MzUy NEVDRkY1QUZGNjgzNzBBAAoJECTs/1r/aDcKxOsQALCvQcpJoXF+DKvRMEicdQpZ H9mbV38UHzs596fDoF6g6Yf1vIITutx3Wgh7AwrPW47mxIh7dzrQtj/SG/0ajA1Y y1L7j2hWF2oUPZyXle5SyubGnSxTtsaAt6UY/QH/G2X35fYTv1NZsoJG2U5HeQ86 00P5gUjNBT3dB1+rywbXh+9uVOQp1wf6JCdC4cKbUty3ywTsSjB2zUi4aTao5tvH fwnNiqWybjUElYS8MyDhLE6/jESgawKqonKUC2F2T44UnEIwJxnf25SMtoM4Etxi tpe6djBtpVwEpCKBnEtoZ7DDbutfl3YpGc97qSdXWcaBLdeqDT8bdCdxmUIVGpPO YkgFbfylRIH5mitSJ0udnAJs4zV1XqYHUPWFalOByiSIQ3uzq83q+FNnXXVSrr43 +8FrDgfBpvkv0ZwhyFagEx86ACZywIum9ceCrSbvFVMYk1ZpwgeSQEHKRF8KkRgw MYbYbEEIqOt0fh2F50Nw991kXtJXGSKkJBb3uuCbVUms1/k8fTrOg60HBfBCc8uL 1SQU6mHbxO5j4xjraSW60iJKpfw8jKDsERXzdsUT6LCxX2kEk9mLcQ8epQT1+sm2 ez4kKbkblqtKgnMIxXQpTBpc83aw4JESMijFnt2wpvfVWfLKyHmZe//zP5znWEDq m4+gRee8gOpz/ACdrwNn =Z0Vs -----END PGP SIGNATURE----- --=-=-=--