From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 23FFB6DE0C71 for ; Sat, 12 Nov 2016 23:35:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.052 X-Spam-Level: X-Spam-Status: No, score=0.052 tagged_above=-999 required=5 tests=[AWL=-0.078, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h3nqeo49N7n5 for ; Sat, 12 Nov 2016 23:35:04 -0800 (PST) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by arlo.cworth.org (Postfix) with ESMTPS id 059D96DE0C64 for ; Sat, 12 Nov 2016 23:35:03 -0800 (PST) Received: by mail-wm0-f67.google.com with SMTP id m203so6852452wma.3 for ; Sat, 12 Nov 2016 23:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=OSc2HG8U6wN2uKht5GQMrA2avmeMyUOJWzXlOkplxew=; b=mdQdHDMJydd0XTL19RenYlyhneyo7dxAndhQ/YrOHLb3QYduCSx69+0aZOBijlAHyd FmKf9g4CmXsWt3UBxXwKigPblj8Sbm3u2Z4+engJhK8ct5PFcY6lZKIET+nNeBCIwfJm odLplNhcBEF/gkgv6VATc3OV62/MAXXPtMHFydJukNJ8odmtkDGAjKOmzJ7mK4PTslyx MQU05i8/ZoEpKuE/0SHmol9Da+wDia5vS13ntJAxM8HMG7zPPx3rVQmjFcWKZ1pa52FK ejqYFsHsnEodwsTAL2FytT4RkAPV5X0CsX2sHVeuo+dM5AYlHd92hRwWaBsVw1AG2G0w +77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=OSc2HG8U6wN2uKht5GQMrA2avmeMyUOJWzXlOkplxew=; b=VsnuiyrX4zpjtCCrKLduI0IM+e+UQPULLKxe9ZkDMY4ZzK9s0smGqKWxDK6fgXNugN jey9UKn+gzV0AsZBHnCqvDraV5JI4LX2zv7PT6eHPX8yQzPzRlh3WaTd8mufd8xgA9wo C1RM6ODcklnkd0X1IprQRwG2BuNDo0G+vXKcqKQycSw8EM/w3kgyNKGA2EbbMZ1ycznr Iz86C+KFt1S0BtPSQlrDYzjPhR2SFqdkVWaspZvL27kzfnOCLeWu++DeAG8AOIYn60ck 8QZXKbDLbanTVZ+b3/oSGGVdgxajxkMM56HdQc+fP76xIvoIicjewyltNPbZ9UVUyz3K /EoQ== X-Gm-Message-State: ABUngveNUd2oH7OM3zhOc/OJd+5bvYlyborioK/PBWupJrNQtXYQmErwE1pRZiPNFr05lw== X-Received: by 10.194.85.107 with SMTP id g11mr14954147wjz.82.1479022501149; Sat, 12 Nov 2016 23:35:01 -0800 (PST) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id 125sm21785916wmh.14.2016.11.12.23.34.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 23:35:00 -0800 (PST) From: Mark Walters To: David Bremner , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook In-Reply-To: <8760nstm24.fsf@tethera.net> References: <87k2ckl9zb.fsf@tesseract.cs.unb.ca> <20161104010243.23316-1-david@tethera.net> <8760nstm24.fsf@tethera.net> Date: Sun, 13 Nov 2016 07:34:59 +0000 Message-ID: <87oa1ju924.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2016 07:35:12 -0000 On Sat, 12 Nov 2016, David Bremner wrote: > Tomi Ollila writes: > >> Like someone (whose message I cannot find just now) mentioned in another >> thread, just now it is right time to mention here too... >> >> https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html >> >> ... that when hook name ends with `-hook` it is supposed to be "normal hook" >> -- a function which does not take arguments nor return values. >> >> So, I'd like to suggest that this variable is renamed to >> notmuch-address-completion-functions >> > > Well, I guess the -functions convention should be followed, but > notmuch-address-completion-functions seems a bit vague. Maybe notmuch-address-post-completion-functions ? Alternatively maybe we can end in -hook-functions to indicate it is a function which is like a hook? Best wishes Mark