From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: v2 _notmuch_message_ensure_metadata exception handling
Date: Sun, 26 Feb 2017 11:16:00 +0200 [thread overview]
Message-ID: <87o9xpgvn3.fsf@nikula.org> (raw)
In-Reply-To: <20170226013512.15868-1-david@tethera.net>
On Sat, 25 Feb 2017, David Bremner <david@tethera.net> wrote:
> I tried to address most of Jani's comments on v1 [1]. The bad news is
> that the test is a bit delicate, it really does need the whole corpus.
Too bad. I hope it's not too dependent on the environment and the phase
of the Moon, etc.
> I did decide to follow the suggestion to make the _reopen function
> private for now. It would be nice if we could hide that complexity
> from library users, I guess we'll have to see.
It's easy enough to expose that later if need be.
The series LGTM.
BR,
Jani.
next prev parent reply other threads:[~2017-02-26 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 1:35 v2 _notmuch_message_ensure_metadata exception handling David Bremner
2017-02-26 1:35 ` [patch v2 1/4] test: add known broken test for uncaught DatabaseModifiedError David Bremner
2017-02-26 1:35 ` [patch v2 2/4] lib: add _notmuch_database_reopen David Bremner
2017-02-26 1:35 ` [patch v2 3/4] lib: handle DatabaseModifiedError in _n_message_ensure_metadata David Bremner
2017-02-26 1:35 ` [patch v2 4/4] lib/message.cc: use view number to invalidate cached metadata David Bremner
2017-02-26 9:16 ` Jani Nikula [this message]
2017-02-26 11:47 ` v2 _notmuch_message_ensure_metadata exception handling David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9xpgvn3.fsf@nikula.org \
--to=jani@nikula.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).