From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 743756DE0A6C for ; Mon, 28 Aug 2017 04:29:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.081 X-Spam-Level: X-Spam-Status: No, score=0.081 tagged_above=-999 required=5 tests=[AWL=-0.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K7XEZkwOPgv3 for ; Mon, 28 Aug 2017 04:29:21 -0700 (PDT) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by arlo.cworth.org (Postfix) with ESMTPS id E5D566DE0A5B for ; Mon, 28 Aug 2017 04:29:20 -0700 (PDT) Received: by mail-wm0-f51.google.com with SMTP id t201so1652570wmt.1 for ; Mon, 28 Aug 2017 04:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=E+HB484tUUJmyUGuHxORhui8RfS0spYHZr9whvVNBzU=; b=VSCUwOAI7gtE4Ec9lkuvf9KjHFzb5MtfBtuk77R+5w3g/L8RUAErDzCI8grsskw8/C bz2CjwnI4pv8jAcoGhXVYRJ5Rf7hBAoJxJaHlJPuOznkLkVtiTikiSzQdFxHnJt/+vBt SNuwixAPMSPHwq95wxSDhvPzVF/J0mVsG0ReRb5/xk50Vdr9BsYtdZrVFnpbIkUFe+yx rYcfZqidnaq7Ih41gQ2sSG4OK9eW/DBG7qVgPg4k2rZItJvsptB0I7OdP+OJRlpdx8F9 ErzyX7cLaz+0chGbU//WvAjuWjENaQM6WXC4URH1r6eWg0Nb5smu7F8BiPfXqV0O+Jp0 7Zvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=E+HB484tUUJmyUGuHxORhui8RfS0spYHZr9whvVNBzU=; b=XsfIXG+m3BHzChihm0qOgTc+zqFNDZpS+c/qFCgLpbuA+7Eh2MRZL6URCrXEKK6fwZ slBdbMMlW/nE2yIPBGUQZqn3RtpB8/weqjTxXw+H5HeCB9rZiMKz5BZKutjLyXyPyEzU el1RfNkfs0/8kx6UusqeYQ3msoQpN48RTdsUAMfFWxOOt0cmj1irrXWaAwLc+PqOAkbx SvWJ/iDcPAzt1FYTBYWXcAwE7z7pIXW+Hq5S0p6RPRUa1dvVb7JYVw/IFdNJqilHdHa1 LQj/9DutWw1a7sImGu4D9KxMrqWiPcPkLhuA+q9U7vehAl0SbsdLioF3QjQZSm3APEp0 7HWw== X-Gm-Message-State: AHYfb5hzxKcqnrh3FBQXDUzs7hFmQO5iaMysNJkepqOd29sEyQrxfChT L6lft4PVZQP8sAdP X-Received: by 10.28.37.7 with SMTP id l7mr159494wml.157.1503919759443; Mon, 28 Aug 2017 04:29:19 -0700 (PDT) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id p36sm183802wrc.79.2017.08.28.04.29.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Aug 2017 04:29:18 -0700 (PDT) From: Mark Walters To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] emacs: show: allow user to insert rfc822 parts as messages In-Reply-To: References: <1503905542-19961-1-git-send-email-markwalters1009@gmail.com> <1503905542-19961-3-git-send-email-markwalters1009@gmail.com> Date: Mon, 28 Aug 2017 12:29:18 +0100 Message-ID: <87o9r0orqp.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 11:29:22 -0000 > >> + (let* ((folder >> + (read-from-minibuffer "Folder/tags to insert part to: " >> + notmuch-show-part-notmuch-insert-folder))) >> + (mm-with-unibyte-buffer >> + (mm-insert-part handle) >> + (notmuch-maildir-fcc-with-notmuch-insert folder nil "Folder/tags to insert part to") >> + (message nil)))) > > Why this? It would be nice to have a comment explaining it. Assuming you mean the message nil bit, This is actually me being dim. I want to remove things like the retry message. But it would be much better to make the insert-part function return something saying whether it succeeded or not, and then give a useful message. Best wishes Mark