From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D04F06DE0B36 for ; Fri, 26 Apr 2019 04:11:05 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.029 X-Spam-Level: X-Spam-Status: No, score=-0.029 tagged_above=-999 required=5 tests=[AWL=-0.028, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id az5J2PbmaBIu for ; Fri, 26 Apr 2019 04:11:04 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 940376DE0B2B for ; Fri, 26 Apr 2019 04:11:04 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hJykv-0000T8-AD; Fri, 26 Apr 2019 07:11:01 -0400 Received: (nullmailer pid 8524 invoked by uid 1000); Fri, 26 Apr 2019 11:10:59 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH] crypto: Avoid pretending to verify signatures on unsigned encrypted mail In-Reply-To: <20190420170257.8189-1-dkg@fifthhorseman.net> References: <20190420170257.8189-1-dkg@fifthhorseman.net> Date: Fri, 26 Apr 2019 08:10:59 -0300 Message-ID: <87o94t9g3g.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 11:11:05 -0000 Daniel Kahn Gillmor writes: > Unsigned encrypted mail shows up with a weird empty signature list. > If we successfully decrypted and there was no signature in it, we > should just not show a sigstatus at all. > > The documentation for g_mime_decrypt_result_get_signatures says: > > a GMimeSignatureList or NULL if the stream was not signed. pushed to master, d