> > So would you like me to patch the namespacing along with these changes > or leave it for another patch? I'd leave namespacing of existing code for a new series if you're motivated to work on that. For your new code, I think it makes most sense to have it in the patch that introduces the code. > >> I assume you are not using git-send-email because it's difficult for >> you; it's not that a big of a deal, although we do prefer series >> generated git-send-email for reviewing. > > I'm using git-send-email on a regular basis, no problem with that. (I > wonder why you would think it's difficult for me :p) My mistake, I assume everyone read https://notmuchmail.org/contributing/#index11h2 ;). > git-send-email comes with different workflows though, I'm not sure which > one Notmuch follows. Do you prefer versioned patch series > (e.g. [PATCHv2], etc.) or patch updates sent with > "--in-reply-to="? For series, probably the former. For single patches, or updates to the single patches in the series, the latter. Thanks! d