From: David Bremner <david@tethera.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree
Date: Sat, 25 May 2019 10:42:56 -0300 [thread overview]
Message-ID: <87o93qmyzj.fsf@tethera.net> (raw)
In-Reply-To: <87woieoj6l.fsf@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]
Pierre Neidhardt <mail@ambrevar.xyz> writes:
> David Bremner <david@tethera.net> writes:
>
>>> --8<---------------cut here---------------start------------->8---
>>>> guix environment notmuch -- /home/ambrevar/.local/share/emacs/site-lisp/notmuch/test/T460-emacs-tree.sh
>>> guix environment: error: execlp: No such file or directory: "/home/ambrevar/.local/share/emacs/site-lisp/notmuch/test/T460-emacs-tree.sh"
>>> --8<---------------cut here---------------end--------------->8---
>>
>> I can't really help you with Guix, but I suggest setting up some
>> environment where you can run things in an interactive shell.
>>
>> In particular that error seems to be claiming the test file doesn't
>> exist, which would be easy to debug in an interactive shell.
>
> Yup, that's what I did with "guix environment notmuch": it sets up a
> build environment (and an interactive shell) for notmuch. And I really
> wonder why it can't find the file, it's there in the interactive shell.
> It's possible that the error message is a red herring though, I'll look
> into it.
I case it helps, attached is the output from
% cd test && ./T460-emacs-tree.sh
Note that the tests do need to be run from that directory.
The two new tests that actually use emacs are failing with output:
*ERROR*: Wrong number of arguments: (1 . 1), 0
Running the tests interactively (just eval testl-lib.el first) suggests
that is output from set-mark-command (in emacs 26.1, it demands at least
one argument).
[-- Attachment #2: test.out --]
[-- Type: application/octet-stream, Size: 14869 bytes --]
T460-emacs-tree: Testing emacs tree view interface
PASS Basic notmuch-tree view in emacs
PASS Refreshed notmuch-tree view in emacs
PASS Tag message in notmuch tree view (display)
PASS Tag message in notmuch tree view (database)
PASS Untag message in notmuch tree view
PASS Untag message in notmuch tree view (database)
PASS Tag thread in notmuch tree view
PASS Tag message in notmuch tree view (database)
PASS Untag thread in notmuch tree view
PASS Untag message in notmuch tree view (database)
FAIL Tag region in notmuch tree view
--- T460-emacs-tree.11.notmuch-tree-tag-inbox-thread-tagged 2019-05-25 13:21:49.729140808 +0000
+++ T460-emacs-tree.11.OUTPUT 2019-05-25 13:21:49.733140808 +0000
@@ -1,53 +0,0 @@
- 2010-12-29 François Boulogne ─►[aur-general] Guidelines: cp, mkdir vs install (inbox unread)
- 2010-12-16 Olivier Berger ─►Essai accentué (inbox unread)
- 2009-11-18 Chris Wilson ─►[notmuch] [PATCH 1/2] Makefile: evaluate pkg-config once (inbox unread)
- 2009-11-18 Alex Botero-Lowry ┬►[notmuch] [PATCH] Error out if no query is supplied to search instead of going into an infinite loop (attachment inbox unread)
- 2009-11-18 Carl Worth ╰─►[notmuch] [PATCH] Error out if no query is supplied to search instead of going into an infinite loop (inbox unread)
- 2009-11-17 Ingmar Vanhassel ┬►[notmuch] [PATCH] Typsos (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Adrian Perez de Cast ┬►[notmuch] Introducing myself (inbox signed unread)
- 2009-11-18 Keith Packard ├─► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Israel Herraiz ┬►[notmuch] New to the list (inbox unread)
- 2009-11-18 Keith Packard ├─► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Jan Janak ┬►[notmuch] What a great idea! (inbox unread)
- 2009-11-17 Jan Janak ├─► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Jan Janak ┬►[notmuch] [PATCH] Older versions of install do not support -C. (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Aron Griffis ┬►[notmuch] archive (inbox unread)
- 2009-11-18 Keith Packard ╰┬► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Keith Packard ┬►[notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (inbox unread)
- 2009-11-18 Carl Worth ╰─►[notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (inbox unread)
- 2009-11-17 Lars Kellogg-Stedman ┬►[notmuch] Working with Maildir storage? (inbox signed test_thread_tag unread)
- 2009-11-17 Mikhail Gusarov ├┬► ... (inbox signed test_thread_tag unread)
- 2009-11-17 Lars Kellogg-Stedman │╰┬► ... (inbox signed test_thread_tag unread)
- 2009-11-17 Mikhail Gusarov │ ├─► ... (inbox test_thread_tag unread)
- 2009-11-17 Keith Packard │ ╰┬► ... (inbox test_thread_tag unread)
- 2009-11-18 Lars Kellogg-Stedman │ ╰─► ... (inbox signed test_thread_tag unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox test_thread_tag unread)
- 2009-11-17 Mikhail Gusarov ┬►[notmuch] [PATCH 1/2] Close message file after parsing message headers (inbox unread)
- 2009-11-17 Mikhail Gusarov ├─►[notmuch] [PATCH 2/2] Include <stdint.h> to get uint32_t in C++ file with gcc 4.4 (inbox unread)
- 2009-11-17 Carl Worth ╰┬►[notmuch] [PATCH 1/2] Close message file after parsing message headers (inbox unread)
- 2009-11-17 Keith Packard ╰┬► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-18 Keith Packard ┬►[notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox unread)
- 2009-11-18 Alexander Botero-Low ╰─►[notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox unread)
- 2009-11-18 Alexander Botero-Low ─►[notmuch] request for pull (inbox unread)
- 2009-11-18 Jjgod Jiang ┬►[notmuch] Mac OS X/Darwin compatibility issues (inbox unread)
- 2009-11-18 Alexander Botero-Low ╰┬► ... (inbox unread)
- 2009-11-18 Jjgod Jiang ╰┬► ... (inbox unread)
- 2009-11-18 Alexander Botero-Low ╰─► ... (inbox unread)
- 2009-11-18 Rolland Santimano ─►[notmuch] Link to mailing list archives ? (inbox unread)
- 2009-11-18 Jan Janak ─►[notmuch] [PATCH] notmuch new: Support for conversion of spool subdirectories into tags (inbox unread)
- 2009-11-18 Stewart Smith ─►[notmuch] [PATCH] count_files: sort directory in inode order before statting (inbox unread)
- 2009-11-18 Stewart Smith ─►[notmuch] [PATCH 2/2] Read mail directory in inode number order (inbox unread)
- 2009-11-18 Stewart Smith ─►[notmuch] [PATCH] Fix linking with gcc to use g++ to link in C++ libs. (inbox unread)
- 2009-11-18 Lars Kellogg-Stedman ┬►[notmuch] "notmuch help" outputs to stderr? (attachment inbox signed unread)
- 2009-11-18 Lars Kellogg-Stedman ╰─► ... (attachment inbox signed unread)
- 2009-11-17 Mikhail Gusarov ─►[notmuch] [PATCH] Handle rename of message file (inbox unread)
- 2009-11-17 Alex Botero-Lowry ┬►[notmuch] preliminary FreeBSD support (attachment inbox unread)
- 2009-11-17 Carl Worth ╰─► ... (inbox unread)
-End of search results.
*ERROR*: Wrong number of arguments: (1 . 1), 0
FAIL Tag region in notmuch tree view (database)
--- T460-emacs-tree.12.expected 2019-05-25 13:21:49.741140808 +0000
+++ T460-emacs-tree.12.output 2019-05-25 13:21:49.741140808 +0000
@@ -1,7 +1 @@
-id:87ocn0qh6d.fsf@yoom.home.cworth.org
-id:20091118005040.GA25380@dottiness.seas.harvard.edu
-id:yunaayketfm.fsf@aiko.keithp.com
-id:87fx8can9z.fsf@vertex.dottedmag
-id:20091117203301.GV3165@dottiness.seas.harvard.edu
-id:87iqd9rn3l.fsf@vertex.dottedmag
-id:20091117190054.GU3165@dottiness.seas.harvard.edu
+
FAIL Untag region in notmuch tree view
--- T460-emacs-tree.13.notmuch-tree-tag-inbox 2019-05-25 13:21:49.865140809 +0000
+++ T460-emacs-tree.13.OUTPUT 2019-05-25 13:21:49.865140809 +0000
@@ -1,53 +0,0 @@
- 2010-12-29 François Boulogne ─►[aur-general] Guidelines: cp, mkdir vs install (inbox unread)
- 2010-12-16 Olivier Berger ─►Essai accentué (inbox unread)
- 2009-11-18 Chris Wilson ─►[notmuch] [PATCH 1/2] Makefile: evaluate pkg-config once (inbox unread)
- 2009-11-18 Alex Botero-Lowry ┬►[notmuch] [PATCH] Error out if no query is supplied to search instead of going into an infinite loop (attachment inbox unread)
- 2009-11-18 Carl Worth ╰─►[notmuch] [PATCH] Error out if no query is supplied to search instead of going into an infinite loop (inbox unread)
- 2009-11-17 Ingmar Vanhassel ┬►[notmuch] [PATCH] Typsos (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Adrian Perez de Cast ┬►[notmuch] Introducing myself (inbox signed unread)
- 2009-11-18 Keith Packard ├─► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Israel Herraiz ┬►[notmuch] New to the list (inbox unread)
- 2009-11-18 Keith Packard ├─► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Jan Janak ┬►[notmuch] What a great idea! (inbox unread)
- 2009-11-17 Jan Janak ├─► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Jan Janak ┬►[notmuch] [PATCH] Older versions of install do not support -C. (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Aron Griffis ┬►[notmuch] archive (inbox unread)
- 2009-11-18 Keith Packard ╰┬► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Keith Packard ┬►[notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (inbox unread)
- 2009-11-18 Carl Worth ╰─►[notmuch] [PATCH] Make notmuch-show 'X' (and 'x') commands remove inbox (and unread) tags (inbox unread)
- 2009-11-17 Lars Kellogg-Stedman ┬►[notmuch] Working with Maildir storage? (inbox signed unread)
- 2009-11-17 Mikhail Gusarov ├┬► ... (inbox signed unread)
- 2009-11-17 Lars Kellogg-Stedman │╰┬► ... (inbox signed unread)
- 2009-11-17 Mikhail Gusarov │ ├─► ... (inbox unread)
- 2009-11-17 Keith Packard │ ╰┬► ... (inbox unread)
- 2009-11-18 Lars Kellogg-Stedman │ ╰─► ... (inbox signed unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-17 Mikhail Gusarov ┬►[notmuch] [PATCH 1/2] Close message file after parsing message headers (inbox unread)
- 2009-11-17 Mikhail Gusarov ├─►[notmuch] [PATCH 2/2] Include <stdint.h> to get uint32_t in C++ file with gcc 4.4 (inbox unread)
- 2009-11-17 Carl Worth ╰┬►[notmuch] [PATCH 1/2] Close message file after parsing message headers (inbox unread)
- 2009-11-17 Keith Packard ╰┬► ... (inbox unread)
- 2009-11-18 Carl Worth ╰─► ... (inbox unread)
- 2009-11-18 Keith Packard ┬►[notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox unread)
- 2009-11-18 Alexander Botero-Low ╰─►[notmuch] [PATCH] Create a default notmuch-show-hook that highlights URLs and uses word-wrap (inbox unread)
- 2009-11-18 Alexander Botero-Low ─►[notmuch] request for pull (inbox unread)
- 2009-11-18 Jjgod Jiang ┬►[notmuch] Mac OS X/Darwin compatibility issues (inbox unread)
- 2009-11-18 Alexander Botero-Low ╰┬► ... (inbox unread)
- 2009-11-18 Jjgod Jiang ╰┬► ... (inbox unread)
- 2009-11-18 Alexander Botero-Low ╰─► ... (inbox unread)
- 2009-11-18 Rolland Santimano ─►[notmuch] Link to mailing list archives ? (inbox unread)
- 2009-11-18 Jan Janak ─►[notmuch] [PATCH] notmuch new: Support for conversion of spool subdirectories into tags (inbox unread)
- 2009-11-18 Stewart Smith ─►[notmuch] [PATCH] count_files: sort directory in inode order before statting (inbox unread)
- 2009-11-18 Stewart Smith ─►[notmuch] [PATCH 2/2] Read mail directory in inode number order (inbox unread)
- 2009-11-18 Stewart Smith ─►[notmuch] [PATCH] Fix linking with gcc to use g++ to link in C++ libs. (inbox unread)
- 2009-11-18 Lars Kellogg-Stedman ┬►[notmuch] "notmuch help" outputs to stderr? (attachment inbox signed unread)
- 2009-11-18 Lars Kellogg-Stedman ╰─► ... (attachment inbox signed unread)
- 2009-11-17 Mikhail Gusarov ─►[notmuch] [PATCH] Handle rename of message file (inbox unread)
- 2009-11-17 Alex Botero-Lowry ┬►[notmuch] preliminary FreeBSD support (attachment inbox unread)
- 2009-11-17 Carl Worth ╰─► ... (inbox unread)
-End of search results.
*ERROR*: Wrong number of arguments: (1 . 1), 0
PASS Untag region in notmuch tree view (database)
PASS Navigation of notmuch-hello to search results
PASS Tree view of a single thread (from search)
PASS Tree view of a single thread (from show)
PASS Message window of tree view
PASS Stash id
PASS Move to next matching message
PASS Move to next thread
PASS Move to previous thread
PASS Move to previous previous thread
[-- Attachment #3: Type: text/plain, Size: 1069 bytes --]
>
> So would you like me to patch the namespacing along with these changes
> or leave it for another patch?
I'd leave namespacing of existing code for a new series if you're
motivated to work on that. For your new code, I think it makes most
sense to have it in the patch that introduces the code.
>
>> I assume you are not using git-send-email because it's difficult for
>> you; it's not that a big of a deal, although we do prefer series
>> generated git-send-email for reviewing.
>
> I'm using git-send-email on a regular basis, no problem with that. (I
> wonder why you would think it's difficult for me :p)
My mistake, I assume everyone read
https://notmuchmail.org/contributing/#index11h2 ;).
> git-send-email comes with different workflows though, I'm not sure which
> one Notmuch follows. Do you prefer versioned patch series
> (e.g. [PATCHv2], etc.) or patch updates sent with
> "--in-reply-to=<message-id-of-the-last-email>"?
For series, probably the former. For single patches, or updates to the
single patches in the series, the latter.
Thanks!
d
next prev parent reply other threads:[~2019-05-25 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 16:47 [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region Pierre Neidhardt
2019-04-09 16:47 ` [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree Pierre Neidhardt
2019-05-08 11:00 ` David Bremner
2019-05-14 10:40 ` Pierre Neidhardt
2019-05-25 11:13 ` David Bremner
2019-05-25 11:41 ` Pierre Neidhardt
2019-05-25 13:42 ` David Bremner [this message]
2019-05-07 9:35 ` [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region David Bremner
2019-05-20 12:35 ` Leo Vivier
2019-05-20 17:11 ` Tomi Ollila
2019-05-22 14:56 ` Leo Vivier
2019-05-23 11:14 ` David Bremner
2019-05-23 11:19 ` Leo Vivier
2019-05-23 17:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o93qmyzj.fsf@tethera.net \
--to=david@tethera.net \
--cc=mail@ambrevar.xyz \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).