From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2C3tNIHSJV/yFQAA0tVLHw (envelope-from ) for ; Sat, 01 Aug 2020 20:37:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uNidMIHSJV85TAAAbx9fmQ (envelope-from ) for ; Sat, 01 Aug 2020 20:37:21 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 493E1940903 for ; Sat, 1 Aug 2020 20:37:20 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BAB792883A; Sat, 1 Aug 2020 16:37:10 -0400 (EDT) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1BB6627B31 for ; Sat, 1 Aug 2020 16:37:06 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 40492160BF; Sat, 1 Aug 2020 22:37:03 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id 0P5FJPaq-Qqp; Sat, 1 Aug 2020 22:37:03 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 0281B160AE; Sat, 1 Aug 2020 22:37:02 +0200 (CEST) From: Jonas Bernoulli To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 03/23] emacs: Fix indentation In-Reply-To: References: <20200726165818.400-1-jonas@bernoul.li> <20200726165818.400-4-jonas@bernoul.li> Date: Sat, 01 Aug 2020 22:37:02 +0200 Message-ID: <87o8nut85t.fsf@bernoul.li> MIME-Version: 1.0 Message-ID-Hash: NOR5LGKCKLIKM6GLWRFKPZ6HPDHNAXYZ X-Message-ID-Hash: NOR5LGKCKLIKM6GLWRFKPZ6HPDHNAXYZ X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.53 X-TUID: AhhzYcClAh0k Tomi Ollila writes: > On Sun, Jul 26 2020, Jonas Bernoulli wrote: >> @@ -473,7 +473,7 @@ (defun notmuch-mua-new-forward-messages (messages &optional prompt-for-sender) >> (when (or prompt-for-sender notmuch-always-prompt-for-sender) >> (list (cons 'From (notmuch-mua-prompt-for-sender))))) >> forward-subject ;; Comes from the first message and is >> - ;; applied later. >> + ;; applied later. > > Otherwise looks good (I think), but this change above... the indentation > emacs does not work here. perhaps appending this 'applied later' to the end > of previous line (even fits onto 80 columns, unlike the next comment... I think we should fix that next comment and handle all three nearby comments consistently, i.e.: diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el --- a/emacs/notmuch-mua.el +++ b/emacs/notmuch-mua.el @@ -476,10 +476,12 @@ (defun notmuch-mua-new-forward-messages (messages &optional prompt-for-sender) (let* ((other-headers (and (or prompt-for-sender notmuch-always-prompt-for-sender) (list (cons 'From (notmuch-mua-prompt-for-sender))))) - forward-subject ;; Comes from the first message and is - ;; applied later. - forward-references ;; List of accumulated message-references of forwarded messages - forward-queries) ;; List of corresponding message-query + ;; Comes from the first message and is applied later. + forward-subject + ;; List of accumulated message-references of forwarded messages. + forward-references + ;; List of corresponding message-query. + forward-queries) ;; Generate the template for the outgoing message. (notmuch-mua-mail nil "" other-headers nil (notmuch-mua-get-switch-function)) (save-excursion