From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KLiaOQMgGGFbEwAAgWs5BA (envelope-from ) for ; Sat, 14 Aug 2021 21:56:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UBZBNQMgGGGXTgAA1q6Kng (envelope-from ) for ; Sat, 14 Aug 2021 19:56:51 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D4B5D134FD for ; Sat, 14 Aug 2021 21:56:50 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 44E421FB74; Sat, 14 Aug 2021 15:56:47 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id B4AD21FB6E for ; Sat, 14 Aug 2021 15:56:44 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 19C6D5FD5C; Sat, 14 Aug 2021 15:56:44 -0400 (EDT) Received: (nullmailer pid 1492900 invoked by uid 1000); Sat, 14 Aug 2021 19:56:41 -0000 From: David Bremner To: Austin Ray , notmuch@notmuchmail.org Subject: Re: [PATCH] lib: load user config. in notmuch_database_open_verbose() In-Reply-To: <20210814193647.3313589-1-austin@austinray.io> References: <20210814193647.3313589-1-austin@austinray.io> Date: Sat, 14 Aug 2021 12:56:41 -0700 Message-ID: <87o89z94w6.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: BBPJFROODFDDGTN7PL6TFLTGZ7445DDC X-Message-ID-Hash: BBPJFROODFDDGTN7PL6TFLTGZ7445DDC X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Austin Ray X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628971010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PURxxOqGmMJbYrNI+vJJEMGsSUugkGMVGPNHlE2XQlo=; b=TKmuwnfVl7ZVO/ShUT/2+2eZteKBRQd1p9dof6kIdmxlqgFCmI7P0te72OiFbVjl+BSdv0 vMuLcOVfh7svj9XHLMWoJEEb38WAreplgQtPRjoWNBBOLHfM8IyciECjL+d0Y8oAtEUwRf j07DLAxEsvvrpkxNCnkrmjRqDzzyLwBXxVGGYt5Evap9AYs/l57Jhv8TBfMers5DiuXpNU 8XJtHTRZhWo4eph2g7AqjMwqQ9S/+w7ZXKJahKWxnndeY/Zf2YqsLJcfCIydE9X87xppxk Yz9q4CU2pOxhH9Dx+W9VN2E/aZCVi44Sdsjgjxv26MvZDiKlNBrbYDoyCP3cuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628971010; a=rsa-sha256; cv=none; b=Lrgor2NzIQ/FGU1fgS+H4th+A8XY4TWTWyrgagkJZRfWlpPNA2KnqSATq2biBz/0QJCdRB yLKyndwvZ2CVz+EvSsY+4lAESwGDvkcA05GG76rSn9VHtCPb1eWkOfC8neNrdQSRLdBe59 AuO7p3FdMwLMrM7/pZDl8+CeY94HcXiS9V8lry5BBVcLXouHkapFdcHj+fVGoy+0AH4Yu9 +ObOUsxTznZA1ofrghopF0EQ44LAhEluyS6yNlmqYo58Y6z6wCB9ylf0FheD6NqfZ3Ge0/ HyS39IV7x51/J1dikKQP05TnEKFcJWlvIQ8kGEwWLpPuF/v2wn7jIhpt02+wHg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D4B5D134FD X-Spam-Score: -1.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: z+zL9NIjGvYd Austin Ray writes: > Docstring for notmuch_database_open_verbose() states it calls > notmuch_database_open_with_config() with "config_path=NULL"; however, > the implementation uses an empty string. This results in libnotmuch > ignoring the user's configuration and may cause issues in downstream > library consumers. > > Signed-off-by: Austin Ray I'm not sure about this. Ignoring the user's configuration is actually the upward compatible thing to do. So maybe it's a doc bug? d