From: David Bremner <david@tethera.net>
To: Austin Ray <austin@austinray.io>, notmuch@notmuchmail.org
Cc: Austin Ray <austin@austinray.io>
Subject: Re: [PATCH] lib: load user config. in notmuch_database_open_verbose()
Date: Sat, 14 Aug 2021 12:56:41 -0700 [thread overview]
Message-ID: <87o89z94w6.fsf@tethera.net> (raw)
In-Reply-To: <20210814193647.3313589-1-austin@austinray.io>
Austin Ray <austin@austinray.io> writes:
> Docstring for notmuch_database_open_verbose() states it calls
> notmuch_database_open_with_config() with "config_path=NULL"; however,
> the implementation uses an empty string. This results in libnotmuch
> ignoring the user's configuration and may cause issues in downstream
> library consumers.
>
> Signed-off-by: Austin Ray <austin@austinray.io>
I'm not sure about this. Ignoring the user's configuration is actually
the upward compatible thing to do. So maybe it's a doc bug?
d
next prev parent reply other threads:[~2021-08-14 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 19:36 [PATCH] lib: load user config. in notmuch_database_open_verbose() Austin Ray
2021-08-14 19:56 ` David Bremner [this message]
2021-08-14 20:48 ` Austin Ray
2021-08-14 21:22 ` David Bremner
2021-08-14 22:40 ` Austin Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o89z94w6.fsf@tethera.net \
--to=david@tethera.net \
--cc=austin@austinray.io \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).