unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: "Jorge P. de Morais Neto" <jorge+list@disroot.org>,
	notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: Notmuch Emacs 0.31.2 documentation and keybinding suggestions
Date: Sun, 10 Oct 2021 22:15:54 -0300	[thread overview]
Message-ID: <87o87ws6np.fsf@tethera.net> (raw)
In-Reply-To: <878sape5a9.fsf@disroot.org>

"Jorge P. de Morais Neto" <jorge+list@disroot.org> writes:

> Hi.  I would like to report the following documentation and keybinding
> imperfections:
>
> The info page
> [[info:notmuch-emacs.info#notmuch-hello key bindings]] says that
> <backspace> moves to the previous widget, but that key is actually bound
> to `delete-backward-char'.

Apparently Tomi "corrected" <backtab> to <backspace> in
703dec7754da477b.

> To move to the previous widget I use <C-M-i>
> or <S-iso-lefttab>.

On the other hand, the keybinding in the code is to "C-<tab>", which
explains the above. To really be <backtab>, it should be S-tab.

> And why does <S-iso-lefttab> move backward but
> <S-C-i> (which ought to be equivalent to <S-iso-lefttab>, no?) moves forward?

You'd think they'd be equivalent, but actually they are not. You can use
C-h k to test, even in a GUI/X11 emacs.

> Also, it seems that <SPC> moves forward and <DEL> moves backward, but
> <S-SPC> does nothing useful.  For consistency with Emacs Info Mode,
> Emacs View Mode, and some other applications such as Firefox, perhaps
> <S-SPC> should move backward too.

I note that S-SPC is not accesible in terminals. But if there's
concensus that is is useful I don't mind adding it.

> The introduction of help buffer for Notmuch-Show (reached by hitting
> <?>) describes the <SPC> command without mentioning that it can archive
> the thread; only in <SPC> specific description (which does not fit in
> the same window; one has to scroll) does it mention the archiving
> behavior.  I believe the archiving behavior should also be mentioned in
> the introduction, lest the user unwittingly archive a thread she wasn't
> supposed to.

I personally don't think archiving is that destructive, if someone wants
to improve this wording, it is the docstring for notmuch-show-mode

> Also, the description for <u> is empty (this also happens
> in the help buffer for Notmuch-Hello).

Yes, that's a bug as the function "notmuch-unthreaded" lacks a
docstring. I think the original author of that code doesn't use emacs
anymore, so someone else is welcome to contribute one.

> In the same help buffer, the description of <c ?> says "Show help for a
> subkeymap."  Would it not be better to drop the "a", leaving "Show help
> for subkeymap." ?

This is the docstring for notmuch-subkeymap-help. In that context I
think it's better with the "a".

> Finally, the binding for <C-tab> in Notmuch-Show and Notmuch-Hello
> inconveniently clobbers the tab-bar-mode binding for that key.  Should
> not Notmuch be content with <C-M-i>/<ESC tab>/<S-iso-lefttab> (and
> possibly <S-C-i>) and leave <C-Tab> alone?
>

Notmuch has used the binding since 2010 (almost 10 years before
tab-bar-mode existed), so people might be used to it; on other hand it
does seem redundant since the binding S-tab is also there. I'm not a
very serious user of notmuch-hello mode, and I don't use tab-bar-mode at
all, so I'd welcome feedback from other people about how attached they
are to C-tab.

  reply	other threads:[~2021-10-11  1:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 17:05 Notmuch Emacs 0.31.2 documentation and keybinding suggestions Jorge P. de Morais Neto
2021-10-11  1:15 ` David Bremner [this message]
2021-10-11 16:49   ` Jose Antonio Ortega Ruiz
2021-10-28 23:33   ` Jorge P. de Morais Neto
2021-10-11 11:19 ` [PATCH] emacs: add minimal docstring for notmuch-unthreaded David Bremner
2021-10-23 13:12   ` [PATCH] emacs: improve notmuch-*-from-current-query docstrings David Bremner
2021-10-30 18:22   ` [PATCH] emacs: add minimal docstring for notmuch-unthreaded David Bremner
2021-10-30 18:35     ` [PATCH] emacs: drop C-tab binding in hello mode, document <backtab> David Bremner
2021-10-30 18:39       ` Ralph Seichter
2021-10-30 18:51         ` David Bremner
2021-10-30 18:58       ` [PATCH v2] " David Bremner
2021-11-03 22:04         ` Tomi Ollila
2021-12-04  0:30         ` David Bremner
2021-12-05 12:39 ` Notmuch Emacs 0.31.2 documentation and keybinding suggestions David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o87ws6np.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=jorge+list@disroot.org \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).