unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: known broken test for top level .notmuch in split configs
@ 2022-01-16 15:25 David Bremner
  2022-07-05 11:11 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: David Bremner @ 2022-01-16 15:25 UTC (permalink / raw)
  To: notmuch

In split configurations there is no special significance to a top
level directory called .notmuch in the mail root. Users should
therefore be able to have mail stored underneath it.
---

My only worry was residual .notmuch directories after people switch
from legacy layout to split, but I tested by copying .notmuch to
.foobar and running notmuch new. It cleverly deduced that none of the
xapian database files were mail files, so this seems fine to me.

 test/T055-path-config.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/test/T055-path-config.sh b/test/T055-path-config.sh
index 1df240dd..40009d09 100755
--- a/test/T055-path-config.sh
+++ b/test/T055-path-config.sh
@@ -316,6 +316,17 @@ db=Database(config=Database.CONFIG.SEARCH)
 m=db.find('20091117232137.GA7669@griffis1.net')
 to=m.header('To')
 print(to)
+EOF
+	   test_expect_equal_file EXPECTED OUTPUT
+
+	   test_begin_subtest ".notmuch not ignored in split config ($config)"
+	   test_subtest_known_broken
+	   generate_message '[dir]=.notmuch/cur' '[subject]="Do not ignore, very important"'
+	   NOTMUCH_NEW > OUTPUT
+	   notmuch search subject:Do-not-ignore | notmuch_search_sanitize >> OUTPUT
+	   cat <<EOF > EXPECTED
+Added 1 new message to the database.
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Do not ignore, very important (inbox unread)
 EOF
 	   test_expect_equal_file EXPECTED OUTPUT
 	   ;;
-- 
2.34.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] test: known broken test for top level .notmuch in split configs
  2022-01-16 15:25 [PATCH] test: known broken test for top level .notmuch in split configs David Bremner
@ 2022-07-05 11:11 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2022-07-05 11:11 UTC (permalink / raw)
  To: notmuch

David Bremner <david@tethera.net> writes:

> In split configurations there is no special significance to a top
> level directory called .notmuch in the mail root. Users should
> therefore be able to have mail stored underneath it.
> ---

applied this old patch to master.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-05 11:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-16 15:25 [PATCH] test: known broken test for top level .notmuch in split configs David Bremner
2022-07-05 11:11 ` David Bremner

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).