[PATCH] test/emacs: adapt to breaking change in Gnus defaults

[PATCH] test/emacs: adapt to breaking change in Gnus defaults

[David Bremner]

As of Emacs 29.1, In-Reply-To is in the default value for
message-hidden-headers. We actually want to see that in the test
suite, so remove it again. To future proof the tests, fix a default
value for message-hidden-headers specifically for the test suite.
---
 test/test-lib.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/test-lib.el b/test/test-lib.el
index 79a9d4d6..236dd99e 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -205,3 +205,8 @@ running, quit if it terminated."
 ;; environments
 
 (setq mm-text-html-renderer 'html2text)
+
+;; Set our own default for message-hidden-headers, to avoid tests
+;; breaking when the Emacs default changes.
+(setq message-hidden-headers
+      '("^References:" "^Face:" "^X-Face:" "^X-Draft-From:"))
-- 
2.40.1

Re: [PATCH] test/emacs: adapt to breaking change in Gnus defaults

[Tomi Ollila]

On Sun, Aug 20 2023, David Bremner wrote:

> As of Emacs 29.1, In-Reply-To is in the default value for
> message-hidden-headers. We actually want to see that in the test
> suite, so remove it again. To future proof the tests, fix a default
> value for message-hidden-headers specifically for the test suite.

--8<--
message-hidden-headers is a variable defined in `message.el'.

Its value is
("^References:" "^Face:" "^X-Face:" "^X-Draft-From:" "^In-Reply-To:")

Regexp of headers to be hidden when composing new messages.
This can also be a list of regexps to match headers.  Or a list
starting with `not' and followed by regexps.

  This variable was introduced, or its default value was changed, in
  version 29.1 of Emacs.
  You can customize this variable.
--8<--

So LGTM (I already thought my X-Face is visible to everyone ;D).

> ---
>  test/test-lib.el | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 79a9d4d6..236dd99e 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -205,3 +205,8 @@ running, quit if it terminated."
>  ;; environments
>  
>  (setq mm-text-html-renderer 'html2text)
> +
> +;; Set our own default for message-hidden-headers, to avoid tests
> +;; breaking when the Emacs default changes.
> +(setq message-hidden-headers
> +      '("^References:" "^Face:" "^X-Face:" "^X-Draft-From:"))
> -- 
> 2.40.1
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

Re: [PATCH] test/emacs: adapt to breaking change in Gnus defaults

[David Bremner]

David Bremner <david@tethera.net> writes:

> As of Emacs 29.1, In-Reply-To is in the default value for
> message-hidden-headers. We actually want to see that in the test
> suite, so remove it again. To future proof the tests, fix a default
> value for message-hidden-headers specifically for the test suite.

Applied to master

d