From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +NRkN6SMd2VtrwAAkFu2QA (envelope-from ) for ; Mon, 11 Dec 2023 23:26:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id YCKiMKSMd2VqdAAAqHPOHw (envelope-from ) for ; Mon, 11 Dec 2023 23:26:44 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=idiomdrottning.org header.s=idiomdrottningorg header.b=e2hBKZ8t; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=idiomdrottning.org (policy=reject) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702333604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=0b2np7T5PA6ZtP8HLrVrIlN+muxuksBmMftu4WYdagU=; b=iwL9Xn3wWGb3LnGfgaOm7C9nx8vaabRSSE/fyq5uyNUDbgFroWtSvap0VcoLYn7Lk9wHXk tWCioV1Ogn1ffinE0xE3zJuaDkjjMIniMMH8gz6Qf8cLMU2H5DhBaUlaI9w63EO+ZbUrxn JEip7hPpuwnZYXkBCmrSdaluhHIGX/FXJd3EH7vukpjzX42vjwLTrUp0wNCpcj3qRSu6Rb a1LU/oXGehJYb4eME3ivL1H6VLlHbb8j2dcizIcpXnqIwJTWPBCpoinkUg3M9lWEmqxwR7 k9tq/9xeL9qK9AYt0UXisLOTAd7xpuy1PlqOmcaNeJ+qJVN4Mg27mfQLVjkg6Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=idiomdrottning.org header.s=idiomdrottningorg header.b=e2hBKZ8t; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=idiomdrottning.org (policy=reject) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702333604; a=rsa-sha256; cv=none; b=V65SJ8eoBjKMbbEvV51Vf1XM5qJo1QlGqrTIK0DO+EUeEIDd7mBkBtuMyNMN1eQ3clFrwN K3LcfC5l6iUo7mfdPaFiUp0PHYsuGnuIJx3CZJLtA2buy/LZGT4woNdkpk+cQDoT3uF+N7 z1vVuBQUNqgQE3gid9pgT/v6x+Di4sFNZd0hV6SzfRbNbw3AAadgS0aTZydiIPFkL+Vayt HhqGQsPk/AbfPv0Q3RdVSpn9pDAIW+9YPITxj+9UFgk+3SndMT2nbC1aZVoDhbymQqZGV3 mIZbI3yDDkQIougG97J/871/Knjl1bKsd1kLRot3w8iUI8fzd53yM7usf2y0sg== Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2384544CF for ; Mon, 11 Dec 2023 23:26:43 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 77D295F36D; Mon, 11 Dec 2023 22:26:35 +0000 (UTC) Received: from halsen.idiomdrottning.org (halsen.idiomdrottning.org [74.207.231.133]) by mail.notmuchmail.org (Postfix) with ESMTPS id DEB5D5E520 for ; Mon, 11 Dec 2023 22:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=idiomdrottning.org; s=idiomdrottningorg; t=1702333590; bh=F3A+ZMIICLTha4OvPLLffqjlhlaBlPDZgaBKNsxhk+4=; h=From:To:Subject:In-Reply-To:References:Date:From; b=e2hBKZ8teMaUV9VsUL6boE2enwaOKhQCAzhpsNz2D5M9FE0Mq557PmloQ15WYn7kd LthwmBds2AeTTXcn0YFr1+Uw6D+ZOrlSpUwVkgyOlluZgYYyfVup2FQ3IV0s4TD7ua M0jk1G3zVM4jjSljB4F4sdfCPnPd4g/pmQTw9G91cNz9wp+5eZ0gFpqZeTwrSht2T0 th+d6vCG9qc9NBu94RvE2GV1/P3fKHGCPnvsQbnPfcrjGGriXKIMWHKcPlbBIwVvi6 FAyP7YAj5Q6YAw1c/fNTkeiDJCABDvY1e1lpFQX1NqjAb+ygZ7UP4TDsyBf+odGajL GArBzi4bzB9HA== Received: from localhost (31-211-247-254.customers.ownit.se [31.211.247.254]) by halsen.idiomdrottning.org (Postfix) with ESMTPSA id 9B12321050; Mon, 11 Dec 2023 23:26:28 +0100 (CET) From: Sandra Snan To: David Bremner , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] Add hook inside notmuch-mua-reply In-Reply-To: <877clkc3dm.fsf@tethera.net> References: <20231210224024.1414315-1-sandra.snan@idiomdrottning.org> <87msuhaqub.fsf@tethera.net> <877clkc3dm.fsf@tethera.net> Autocrypt: addr=sandra.snan@idiomdrottning.org; prefer-encrypt=mutual; keydata= mDMEZWEIEhYJKwYBBAHaRw8BAQdAahVPtpoqkiV62AL3GSY4JaPS0i3Bu3fhbe5WIFQG9pa0LFNh bmRyYSBTbmFuIDxzYW5kcmEuc25hbkBpZGlvbWRyb3R0bmluZy5vcmc+iJMEExYIADsCGwMFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AWIQSM+QwgZjV9IBEt0Difw0TKEvFISgUCZWJbSgIZAQAKCRCf w0TKEvFIShsYAPsFMXn+tFcAwdI2hrkqqQY8I5EC9UWYC9t57VjiYv2uYQD+PUNVHVSBGQDycf3V /nXqXvZvTfcFMOz0PVMzibPl0AiIkAQTFggAOBYhBIz5DCBmNX0gES3QOJ/DRMoS8UhKBQJlYQgS AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEJ/DRMoS8UhK07EA/iV2B5e3r8t8/StJT38d x9YbuoSBmbYZJ6JHH9hoyv0hAPwMiH1M8zZUeQK/TQDqkg2Hjk0xL+U7i9ggocLJEAWQDbg4BGVh CBISCisGAQQBl1UBBQEBB0BqHjRRmoXeZmeeUZOqL1ebAflzYFA3jHwxl2sLMLlMCgMBCAeIeAQY FggAIBYhBIz5DCBmNX0gES3QOJ/DRMoS8UhKBQJlYQgSAhsMAAoJEJ/DRMoS8UhK4o0BAOB7ChkN Jc0oxRDg9WvrbUCnpLU/QdjMFcC8ymLRdzxaAP4gZVL0JQfxulc/JAxotCevk1PAF+UXpY8QalTI dooaAA== Date: Mon, 11 Dec 2023 23:26:27 +0100 Message-ID: <87o7ews7e4.fsf@ellen.idiomdrottning.org> MIME-Version: 1.0 Message-ID-Hash: AP26ILDPHHXSAEG7ZIZYKUAGRNMXQNEY X-Message-ID-Hash: AP26ILDPHHXSAEG7ZIZYKUAGRNMXQNEY X-MailFrom: sandra.snan@idiomdrottning.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: 7bit Content-Type: text/plain; format="flowed"; charset="us-ascii" X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: 6.00 X-Migadu-Spam: Yes X-Migadu-Queue-Id: C2384544CF X-Spam: Yes X-Spam-Score: 6.00 X-TUID: PnzDByavaNZQ I missed the other notes. I'll do a v3 renaming to notmuch-mua-reply-functions. The reason I need message-id is because I need to call notmuch again to get other headers beyond what's included in the sexp, including autocrypt. But the suggestion to jam the entire sexp is good. I did that for v2. It's not more expensive for Emacs to do that since it's all cons cells anyway. I can just as easily grab it from the plist in the hooked function as I could in notmuch-mua-reply itself. David Bremner writes: > Tomi Ollila writes: >> >> another thing what should be the parameters passed, and why. this change >> adds (just) message-id but no reasoning (nor documentation) there... >> > > I wonder if we should pass the whole (parsed) original message, for > maximum flexibility?