From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2MdME6Zno2Z0IwEA62LTzQ:P1 (envelope-from ) for ; Fri, 26 Jul 2024 09:08:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 2MdME6Zno2Z0IwEA62LTzQ (envelope-from ) for ; Fri, 26 Jul 2024 11:08:54 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=idiomdrottning.org header.s=idiomdrottningorg header.b=oYzQILOH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=idiomdrottning.org (policy=reject); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721984934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=YSsAQ0gn0AKaclXJ/qvIESPYgsfF7k/cUAxt1ODz0lA=; b=HS8plmq7pQ+DMY2F27hGIxVKc6d4ythPNcCFv6nNq10pl6Yj8XLRAVRlLbq25KfP44pTA7 SAuPI58WQoBihqkJraNbXsHntTIt6vrmeEjrwmp7ChS9rm6fbyEKX2HGY5iIodkPyTP4NE XxbPMauGiO96Nm0MR6l28SUsN0rKHbBDSWhTkcJqGpL/XTBbofask4F/U6NTbDEcwh8nKM 2/Kfw5K2WfNkm0oMbwrUMCJ7EiRar5c+YFqkWQb9aQf9w4RqEdMi7/6STC24L6i5/JCzNF C8PoXiTkc6jeKhmCK2UC/fhhLcKN1769aDXxAS8vaN+gtyNu7hR7/CehFBPHKQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721984934; a=rsa-sha256; cv=none; b=LR6ybcc6kHtT3SbZzPLrcfDaXSzuJnULZL0gdnreFV0/gZZBMUnRvRf8CNV71bnwNNxhrb q4G189LEBLk/3BFndfFtFNaVyp+uciBdbYGAQSEAlUjie3ICVeUciLNzdldC4SDXB0I1Ab Czqnmamu+EI9oijHl6wDWOTuXGCM4GWk69fFRQBSG67ZgH7wj5RPcULBe8kt6UlAFjVPFR z7VtHmxotOfbZUuiUwNLYMpR14ZQYEHjXjpciF9sNRjyn3wp747XRtr6CikkKbuIuL89+Y U24iZWbmbtK7RYpcylf9WLIcNw7Axmu5HHm0qaHE+v0XndvVM7PkOpi0YYhpBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=idiomdrottning.org header.s=idiomdrottningorg header.b=oYzQILOH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=idiomdrottning.org (policy=reject); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F083962F66 for ; Fri, 26 Jul 2024 11:08:52 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 41F295F7B0; Fri, 26 Jul 2024 09:08:44 +0000 (UTC) X-Greylist: delayed 351 seconds by postgrey-1.36 at yantan; Fri, 26 Jul 2024 09:08:42 UTC Received: from halsen.idiomdrottning.org (halsen.idiomdrottning.org [IPv6:2600:3c02:e000:179::7]) by mail.notmuchmail.org (Postfix) with ESMTPS id 26C385F367 for ; Fri, 26 Jul 2024 09:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=idiomdrottning.org; s=idiomdrottningorg; t=1721984567; bh=1pFgFWPJfcSn5yojgHKDvdehMFTBxfstDiIduKZJ4wM=; h=From:To:Subject:In-Reply-To:References:Date:From; b=oYzQILOHQ8k2VFUK/NLHNUVEwrD14/h5HLAGg+3AMz8+vmzidutpjCvQaQ2UE/VR7 y9+xFad+Tb9yR8WMOD65h2eZp/brmSh9EQNNLpj8FdGskC9gITdIOjfnP4KOjdG2k6 6is5vWnVSbKECOvCPmYcQbPynJzeg7xyzLq0Wp2LVJU3WOBkQK7BPhZjWSDmG44nwZ nGo0gr7pnx6WjTX0EMiHXnLVok2FC8UawlcGrULRq8XYzauTMPZ1wpyv8IiXj6l+q2 sEU1nYwh3tCXeslnKGPtP9ukebgS82rLHspfEtZ8hAwL7JtX9XZ9UlKJbZpxPkBcK7 KJc37eoIbsB9w== Received: from localhost (31-211-247-254.customers.ownit.se [31.211.247.254]) by halsen.idiomdrottning.org (Postfix) with ESMTPSA id A6C991EC8F; Fri, 26 Jul 2024 11:02:45 +0200 (CEST) From: Sandra Snan To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] Add notmuch-search-show-or-unthread In-Reply-To: <87v80tiu60.fsf@tethera.net> References: <20231207170247.504315-1-sandra.snan@idiomdrottning.org> <20231207170247.504315-2-sandra.snan@idiomdrottning.org> <87v80tiu60.fsf@tethera.net> Autocrypt: addr=sandra.snan@idiomdrottning.org; prefer-encrypt=mutual; keydata= mDMEZWEIEhYJKwYBBAHaRw8BAQdAahVPtpoqkiV62AL3GSY4JaPS0i3Bu3fhbe5WIFQG9pa0LFNh bmRyYSBTbmFuIDxzYW5kcmEuc25hbkBpZGlvbWRyb3R0bmluZy5vcmc+iJMEExYIADsCGwMFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AWIQSM+QwgZjV9IBEt0Difw0TKEvFISgUCZWJbSgIZAQAKCRCf w0TKEvFIShsYAPsFMXn+tFcAwdI2hrkqqQY8I5EC9UWYC9t57VjiYv2uYQD+PUNVHVSBGQDycf3V /nXqXvZvTfcFMOz0PVMzibPl0AiIkAQTFggAOBYhBIz5DCBmNX0gES3QOJ/DRMoS8UhKBQJlYQgS AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEJ/DRMoS8UhK07EA/iV2B5e3r8t8/StJT38d x9YbuoSBmbYZJ6JHH9hoyv0hAPwMiH1M8zZUeQK/TQDqkg2Hjk0xL+U7i9ggocLJEAWQDbg4BGVh CBISCisGAQQBl1UBBQEBB0BqHjRRmoXeZmeeUZOqL1ebAflzYFA3jHwxl2sLMLlMCgMBCAeIeAQY FggAIBYhBIz5DCBmNX0gES3QOJ/DRMoS8UhKBQJlYQgSAhsMAAoJEJ/DRMoS8UhK4o0BAOB7ChkN Jc0oxRDg9WvrbUCnpLU/QdjMFcC8ymLRdzxaAP4gZVL0JQfxulc/JAxotCevk1PAF+UXpY8QalTI dooaAA== Date: Fri, 26 Jul 2024 11:02:44 +0200 Message-ID: <87o76kwmob.fsf@ellen.idiomdrottning.org> MIME-Version: 1.0 Message-ID-Hash: KLVBLVT2U2H52U26WIDRZNQ2TIVAFKAV X-Message-ID-Hash: KLVBLVT2U2H52U26WIDRZNQ2TIVAFKAV X-MailFrom: sandra.snan@idiomdrottning.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: 7bit Content-Type: text/plain; format="flowed"; charset="us-ascii" X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: 2.11 X-Spam-Score: 2.11 X-Migadu-Queue-Id: F083962F66 X-Migadu-Scanner: mx11.migadu.com X-TUID: c1jJm5HlzF8s David Bremner writes: > 1) can you make a test (probably something in T465 can serve as > a model What does T465 refer to? > 2) Should this be bound by default, or is the function in the > next patch always the one users will want? The latter since it prevents crashes. I've been dogfooding this since I made it. It's been so great since I have huge threads that used to overload Emacs and that's finally no longer a problem. >> "Big" is hardcoded to ten messages or lower, if we want to >> introduce a variable for that instead, that might be great. > > Yes, I think a defcustom is called for. Right. Even if we find the perfect number and set that as the default, it's just good Emacs practice to make it a defcustom. > Some of that explanation can maybe go in the docstring of the > newly defined customize variable I'll try! > emacs wants to indent this line differently, so please follow > its lead here. Wilco! > One option is to replace the default notmuch-search-show-thread > binding Yes, that's what I've done locally. An even stronger step in that direction would be to make this the new notmuch-search-show-thread. > and just set the threshhold very high so that most users will > not notice the change. But if the treshhold is too big it won't prevent any crashes, overloads, or uncomfortably unergonomic thread view. It needs to be within a useful range. Maybe 35, 40 or so. I've been sticking with the "< 11" threshold I sent in the patch. > There is a slight performance penalty from add notmuch count; > I'm not sure if this is noticable. Right. Since my machine is very fast I've not noticed any slowdown at all. It's instant. A drawback of working on a fast machine, I don't know what's too slow for more retro-minded users. But even though my machine is fast it still couldn't handle the big threads.