From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
David A Benjamin <davidben@MIT.EDU>,
Ben Gamari <bgamari.foss@gmail.com>
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: Notmuch command interface
Date: Sun, 14 Mar 2010 19:15:45 +0100 [thread overview]
Message-ID: <87mxyabwha.fsf@steelpick.localdomain> (raw)
In-Reply-To: <87k4thplxj.fsf@SSpaeth.de>
On Fri, 12 Mar 2010 17:03:04 +0100, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
> On Fri, 12 Mar 2010 16:03:34 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > On Fri, 12 Mar 2010, Sebastian Spaeth wrote:
> > > > Unfortunately, I didn't make much progress in implementating this, but
> > > > it's definitely a priority for me because I want to get rid of slow
> > > > notmuchsync.
> > >
> > > notmuchsync master is now using the json output, by the way. I think
> > > that suppressing the output of msg bodies in notmuch show will help
> > > notmuchsync performance *a lot*.
> >
> > I've just tried it :-(
> > File "/usr/lib/pymodules/python2.5/simplejson/decoder.py", line 353, in raw_decode
> > raise ValueError("No JSON object could be decoded")
> > ValueError: No JSON object could be decoded
>
> Wow, that is bad. All it does is taking "nomuch show" output and feeding
> it to the json parser. That probably means that the json was not valid
> (which would be bad).
Yes. I found that the problem is caused by emails with an empty body.
I'll post a patch to fix this in a while.
> Having said that, I remember that I got that when I used a notmuch that
> doesn't include the notmuch tags in the json output, ie you need notmuch
> from current master less than 26h ago. Do you use that?
>
> Also Python 2.6 is a requirement, but I see you used that already...
Strange, I use default python from Debian which is 2.5.5 and current
notmuchsync master runs without problems.
-Michal
next prev parent reply other threads:[~2010-03-14 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 15:25 Notmuch command interface Ben Gamari
2010-03-11 22:52 ` David A Benjamin
2010-03-12 0:52 ` Ben Gamari
2010-03-12 8:31 ` Michal Sojka
2010-03-12 14:46 ` Sebastian Spaeth
2010-03-12 15:03 ` Michal Sojka
2010-03-12 16:03 ` Sebastian Spaeth
2010-03-14 18:15 ` Michal Sojka [this message]
2010-03-14 18:19 ` [PATCH] Produce valid JSON output even if mail body is empty Michal Sojka
2010-03-14 19:01 ` James Westby
2010-03-14 20:44 ` [PATCH] Fix invalid JSON output for NULL strings Michal Sojka
2010-03-12 9:18 ` Notmuch command interface Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxyabwha.fsf@steelpick.localdomain \
--to=sojkam1@fel.cvut.cz \
--cc=Sebastian@SSpaeth.de \
--cc=bgamari.foss@gmail.com \
--cc=davidben@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).