From: Carl Worth <cworth@cworth.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Prevent data loss caused by SIGINT during notmuch new
Date: Tue, 13 Apr 2010 08:47:04 -0700 [thread overview]
Message-ID: <87mxx7e4nb.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1269937403-8495-1-git-send-email-sojkam1@fel.cvut.cz>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On Tue, 30 Mar 2010 10:23:23 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> When Ctrl-C is pressed in a wrong time during notmuch new, it can lead
> to removal of messages from the database even if the files were not
> removed.
>
> It happened at least once to me.
>
> Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
Thanks so much, Michal!
This was a very bad bug that I'm sure I introduced myself when
implementing rename support.
Thanks to Sebastian for reminding me to pick this up for the 0.2
release.
And, everyone, if I'm behind on patches, (which has always been the case
so far with this project...), please feel free to make plenty of noise
when there are known fixes for data-loss bugs. We really shouldn't let
those sit for a couple of weeks!
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2010-04-13 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 21:18 [PATCH] Prevent data loss caused by SIGINT during notmuch new Michal Sojka
2010-03-27 23:37 ` Sebastian Spaeth
2010-03-28 1:53 ` Sebastian Spaeth
2010-03-28 4:28 ` Michal Sojka
2010-03-29 7:16 ` Sebastian Spaeth
2010-03-29 23:20 ` spaetz
2010-03-30 8:22 ` Michal Sojka
2010-03-30 8:23 ` Michal Sojka
2010-04-13 15:47 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxx7e4nb.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).