unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Michal Sojka <sojkam1@fel.cvut.cz>
To: meskio@sindominio.net, notmuch@notmuchmail.org
Subject: [PATCH] Additional maildir-sync test
Date: Sun, 21 Nov 2010 00:54:20 +0100	[thread overview]
Message-ID: <87mxp3k0ur.fsf@wsheee.2x.cz> (raw)
In-Reply-To: <87pqtzk254.fsf@wsheee.2x.cz>

On Sat, 20 Nov 2010, Michal Sojka wrote:
> your patch fixes the problem, but it also breaks one of the tests in
> test suite. I created the test for your patch ...

and here is another test which was in my original synchronization
patches, but Carl decided to remove it. It checks that tagging message
by an unrelated tag does not move the message from new to cur. This test
currently fails.

In id:"20100323143714.GE28596@blackspot" Ruben wrote that for some mail
readers there is a difference between mails in new and mails without "S"
flag in cur.

Ruben, is the current behavior problematic for you?

Carl, did you have some reason to remove this functionality?

-Michal

diff --git a/test/maildir-sync b/test/maildir-sync
index 4419a7e..8da12dd 100755
--- a/test/maildir-sync
+++ b/test/maildir-sync
@@ -185,4 +185,10 @@ add_message [subject]='"Message in new without maildir info"' [date]='"Sat, 01 J
 output=$(notmuch search subject:"Message in new without maildir info" | notmuch_search_sanitize)
 test_expect_equal "$output" "thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; Message in new without maildir info (inbox unread)"
 
+test_begin_subtest "Non-maildir-syncable tag should not move the message from new"
+add_message [subject]='"Message to stay in new after tagging"' [date]='"Sat, 01 Jan 2000 12:00:00 -0000"' [filename]='message-to-stay-in-new-after-tagging' [dir]=new
+notmuch tag +non-maildir-syncable subject:"Message to stay in new after tagging"
+output=$(cd "$MAIL_DIR"; find -name 'message-to-stay-in-new-after-tagging*')
+test_expect_equal "$output" "./new/message-to-stay-in-new-after-tagging"
+
 test_done

  parent reply	other threads:[~2010-11-20 23:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11 13:04 Maildir-flags synchronization now on master branch Carl Worth
2010-11-11 14:11 ` Kristoffer Ström
2010-11-11 22:38   ` Carl Worth
2010-11-12  0:43 ` Carl Worth
2010-11-12  1:43   ` Dirk Hohndel
2010-11-18 15:37 ` Ruben Pollan
2010-11-19 15:41   ` [PATCH] Including 'unread' tag to mails without maildir flags meskio
2010-11-20 23:26     ` Michal Sojka
2010-11-20 23:27       ` [PATCH 1/2] test: Add test for messages without maildir info in new Michal Sojka
2010-11-20 23:27       ` [PATCH 2/2] Include 'unread' tag only to mails " Michal Sojka
2010-11-22 10:43         ` Ruben Pollan
2010-11-20 23:54       ` Michal Sojka [this message]
2010-11-22 10:41         ` [PATCH] Additional maildir-sync test Ruben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxp3k0ur.fsf@wsheee.2x.cz \
    --to=sojkam1@fel.cvut.cz \
    --cc=meskio@sindominio.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).