* fix for Debian build failures
@ 2010-12-14 3:05 David Bremner
0 siblings, 0 replies; only message in thread
From: David Bremner @ 2010-12-14 3:05 UTC (permalink / raw)
To: notmuch
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
resent because of subscription issues.
I think the following patch might fix the build failures on Debian. The
idea is to kill the test before the build process kills the whole build.
Let me know if you'd like me to prepare an upload of 0.5+this-patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch to add timeout to emacs tests --]
[-- Type: text/x-diff, Size: 1367 bytes --]
From a060745745d82dc9531ed456428420f26ad2833b Mon Sep 17 00:00:00 2001
From: David Bremner <bremner@unb.ca>
Date: Mon, 13 Dec 2010 22:00:47 -0400
Subject: [PATCH] tests: Add optional use of timeout utility, if present. Add to emacs tests.
The goal here is to treat a hung test as a failure. The emacs test for
sending mail is known to be problematic on the debian
autobuilders. This is both a bandaid fix for that, and a sensible long
term feature.
Currently a fixed timeout of 5 minutes is used.
---
test/test-lib.sh | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 418eaa7..639e6ae 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -793,7 +793,7 @@ emacs \$BATCH --no-init-file --no-site-file \
--eval "(progn (set-frame-width (window-frame (get-buffer-window)) 80) \$@)"
EOF
chmod a+x ./run_emacs
- ./run_emacs "$@"
+ $TEST_TIMEOUT_CMD ./run_emacs "$@"
}
@@ -986,3 +986,11 @@ test -z "$NO_PYTHON" && test_set_prereq PYTHON
# test whether the filesystem supports symbolic links
ln -s x y 2>/dev/null && test -h y 2>/dev/null && test_set_prereq SYMLINKS
rm -f y
+
+# test for timeout utility
+if command -v timeout >/dev/null; then
+ TEST_TIMEOUT_CMD="timeout 5m "
+else
+ TEST_TIMEOUT_CMD=""
+fi
+echo $TEST_TIMEOUT_CMD
\ No newline at end of file
--
1.7.2.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-12-14 3:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-14 3:05 fix for Debian build failures David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).