From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show
Date: Mon, 28 Nov 2011 22:11:43 +0400 [thread overview]
Message-ID: <87mxbgw200.fsf@gmail.com> (raw)
In-Reply-To: <87lir0xr3g.fsf@servo.finestructure.net>
Hi Jamie.
On Mon, 28 Nov 2011 06:24:19 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > -(defun notmuch-show-get-header (header)
> > +(defun notmuch-show-get-header (header &optional props)
> > "Return the named header of the current message, if any."
> > - (plist-get (notmuch-show-get-prop :headers) header))
> > + (plist-get (notmuch-show-get-prop :headers props) header))
>
> Hey, Dmitry. It looks like the new plist-get call is assuming props is
> defined, but it looks like it's only optional in the argument list.
> Wouldn't the function fail if the props argument is not supplied?
>
If props is not supplied it is bound to nil. There is no special
"undefined" value.
Regards,
Dmitry
> jamie.
next prev parent reply other threads:[~2011-11-28 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 22:23 [PATCH 1/2] emacs: remove some code duplication in notmuch-show Dmitry Kurochkin
2011-11-25 22:23 ` [PATCH 2/2] emacs: remove unused variable in `notmuch-show-insert-part-message/rfc822' Dmitry Kurochkin
2011-11-28 2:30 ` [PATCH 1/2] emacs: remove some code duplication in notmuch-show Austin Clements
2011-11-28 14:24 ` Jameson Graef Rollins
2011-11-28 18:11 ` Dmitry Kurochkin [this message]
2011-11-28 18:28 ` Austin Clements
2011-11-28 19:51 ` Jameson Graef Rollins
2011-12-07 15:14 ` Dmitry Kurochkin
2011-12-08 1:02 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxbgw200.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).