From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 67F3B431FAE for ; Fri, 3 Feb 2012 13:25:03 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8QtTU-+kt+3Q for ; Fri, 3 Feb 2012 13:25:01 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 25692431FAF for ; Fri, 3 Feb 2012 13:25:01 -0800 (PST) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 83720328071; Fri, 3 Feb 2012 13:24:58 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (gwave-82.ligo.caltech.edu [131.215.114.82]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id D39782E50DDE; Fri, 3 Feb 2012 13:24:55 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id C7E432E6; Fri, 3 Feb 2012 13:24:55 -0800 (PST) From: Jameson Graef Rollins To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file In-Reply-To: <87sjishv3e.fsf@gmail.com> References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com> <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> <87zkd1p12c.fsf@servo.finestructure.net> <87sjishv3e.fsf@gmail.com> User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 03 Feb 2012 13:24:53 -0800 Message-ID: <87mx8zobiy.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2012 21:25:03 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin wrote: > Actually, we can do both: check file name for consistent diff order > (from expected to actual) and use file names that the caller provides. >=20 > What do you think? I'm not sure it's worth it, but I suppose that's fine. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPLFClAAoJEO00zqvie6q8oQAP/0VAagnh67QVgN3vkReKGxDw wFTvck8iZP8eDXv06dh+n4OUy8KALt7osGW/HmeCy5GqGadVaWX95iTXdKhyHTnF P2l9Z7wr4iDSXzIjStYO2ZAXS3YkbrLRi6wAiLnW8Lxh3yoBRZIa1memrIEcgE+d yF29iOLiBusTQP6uuepuZ8VvuZb3AjWAlNQf+pH4RAuHnCB9Z2rEkgtoh+iygR9e R217ZctflwmPFMqPHKACc5PyVinDeCqGhcfi1YMxT1hnKtTDXncZmeUPDjkVA4zM SfOvIv/RegIXz0mUkdAqhcL2obdEQJMz6UreNpsZkH2iXwnES8zVgqqYUkxvTXQn TEy3+hygNar0Kq7AaMDjSJlUTaWwlKyLNbPO+m3x1owq2yCG2yR54tum7yl0r57E AsHGehNlTPxz86GEB3JcFWE5z6LWaTDAbSfZ+RI4AXlSQrggLqy4hHb+6K0n2H2U 0M4GuSIECxpmw25d4YH7CR9xZuO3j4hsN165Oo34w/mI0Y8PjP/4ZN4oFZC5TBUG ZttJPpifTqfd0lBC/ejA5v9pZrNM44eCTnw2JZeUG2GESMvCNZBH9vxcsQ7/CQzU /nwBzKkWjGQiX2hC5k9LdIiFlsgLJqULPgNsSX0i8sJ08EbbngHbHWB+bz0zfNRg 30R4kAdAJjbXgfVaMMO8 =cpGo -----END PGP SIGNATURE----- --=-=-=--