From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/6] Finish show rewrite
Date: Sat, 14 Apr 2012 12:43:57 -0700 [thread overview]
Message-ID: <87mx6eyu82.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1333846670-5356-1-git-send-email-amdragon@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Sat, Apr 07 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> The long-awaited and oft-belated conclusion of the show rewrite. All
> of the formatters have been converted to the new style, so this series
> just rips out unused code and does a little cleanup.
LGTM, tested, and +1.
This has been a truly epic endeavor, Austin, and the result is
phenomenal. The show code is much cleaner, more efficient, and better
functioning. Thank you so much for working through it all and pushing
it through to the end. Kudos.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-04-14 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 0:57 [PATCH 0/6] Finish show rewrite Austin Clements
2012-04-08 0:57 ` [PATCH 1/6] Sync schemata with current code structure Austin Clements
2012-04-08 0:57 ` [PATCH 2/6] show: Remove support for old-style formatters in show_message Austin Clements
2012-04-08 0:57 ` [PATCH 3/6] Remove show-message.c Austin Clements
2012-04-08 0:57 ` [PATCH 4/6] show: Remove unused fields from notmuch_show_format Austin Clements
2012-04-08 0:57 ` [PATCH 5/6] show: Support NULL values for message_set_{start, sep, end} Austin Clements
2012-04-08 0:57 ` [PATCH 6/6] show: Remove empty message_set_{start,sep,end} fields Austin Clements
2012-04-11 19:11 ` [PATCH 0/6] Finish show rewrite Tomi Ollila
2012-04-13 12:33 ` Mark Walters
2012-04-14 19:43 ` Jameson Graef Rollins [this message]
2012-04-15 12:45 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx6eyu82.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).