From: James Vasile <james@hackervisions.org>
To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>,
notmuch mailing list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] fix notmuch_database_open call in addrlookup
Date: Wed, 07 Nov 2012 20:45:29 -0500 [thread overview]
Message-ID: <87mwyseukm.fsf@jamesvasile.com> (raw)
In-Reply-To: <87y5idijfx.fsf@jamesvasile.com>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
James Vasile <james@hackervisions.org> writes:
> Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:
>
>> James Vasile <james@hackervisions.org> writes:
>>
>>> What's the best way to submit changes to addrlookup? Right now, it is
>>> out of date vs the latest libnotmuch. The addrlookup repo is vala code
>>> but the wiki [1] points to a generated c file [2].
>>>
>>> [1] http://github.com/spaetz/vala-notmuch/raw/static-sources/src/addrlookup.c
>>> [2] http://notmuchmail.org/emacstips/
>>>
>>> At any rate, a patch to that c file is below. If you upgraded notmuch
>>> and now addrlookup gives errors about not finding libnotmuch.so.2, this
>>> patch might be what you need.
>>
>> I'd try to contact the author of the code, perhaps by submitting an
>> issue or pull request on the github page for the project. I'm sure he'd
>> prefer a patch to the Vala source.
>>
>> Ethan
>
> Thanks, will do. My vala is weak, so a patch to the vala source is
> unlikely to make it to the front of my queue this year. I'll ping
> Sebastian Spaeth directly and via github.
>
> -J
Just to close the loop: I contacted Sebastian and he applied my patch.
I tested the instructions on the wiki and confirmed they are currently
correct against his tree. He notes that he doesn't currently have time
to monitor the list closely.
Thanks,
-J
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
prev parent reply other threads:[~2012-11-08 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 16:43 [PATCH] fix notmuch_database_open call in addrlookup James Vasile
2012-11-06 4:01 ` Ethan Glasser-Camp
2012-11-07 14:20 ` James Vasile
2012-11-08 1:45 ` James Vasile [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwyseukm.fsf@jamesvasile.com \
--to=james@hackervisions.org \
--cc=ethan.glasser.camp@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).