unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <aclements@csail.mit.edu>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: fix an evident copy-paste error in argument parsing test
Date: Mon, 03 Dec 2012 18:15:58 -0500	[thread overview]
Message-ID: <87mwxuybf5.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1354575292-8680-1-git-send-email-jani@nikula.org>

On Mon, 03 Dec 2012, Jani Nikula <jani@nikula.org> wrote:
> ---
>  test/arg-test.c       |    2 +-
>  test/argument-parsing |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/arg-test.c b/test/arg-test.c
> index adc56e3..6c49eac 100644
> --- a/test/arg-test.c
> +++ b/test/arg-test.c
> @@ -41,7 +41,7 @@ int main(int argc, char **argv){
>  	printf("positional arg 1 %s\n", pos_arg1);
>  
>      if (pos_arg2)
> -	printf("positional arg 2 %s\n", pos_arg1);
> +	printf("positional arg 2 %s\n", pos_arg2);
>  
>  
>      for ( ; opt_index < argc ; opt_index ++) {
> diff --git a/test/argument-parsing b/test/argument-parsing
> index 672de0b..94e9087 100755
> --- a/test/argument-parsing
> +++ b/test/argument-parsing
> @@ -9,7 +9,7 @@ keyword 1
>  int 7
>  string foo
>  positional arg 1 pos1
> -positional arg 2 pos1
> +positional arg 2 pos2

Someone obviously didn't check their test output.

>  EOF
>  test_expect_equal_file OUTPUT EXPECTED
>  

LGTM.

  reply	other threads:[~2012-12-03 23:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 22:54 [PATCH] test: fix an evident copy-paste error in argument parsing test Jani Nikula
2012-12-03 23:15 ` Austin Clements [this message]
2012-12-04 13:14 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwxuybf5.fsf@awakening.csail.mit.edu \
    --to=aclements@csail.mit.edu \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).