From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] crypto: return NULL cryptoctx if protocol string is empty.
Date: Fri, 19 Jul 2013 08:57:52 -0700 [thread overview]
Message-ID: <87mwpi8run.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1374248172-14199-1-git-send-email-jrollins@finestructure.net>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Fri, Jul 19 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Badly formed messages that don't specify a protocol in
> signed/encrypted parts, end up with a protocol of NULL. strcasecmp in
> notmuch_crypto_get_context then segfaults when trying to check it
> against known protocols. If the protocol is NULL, just return an
> empty context immediately (with appropriate message.)
Fixes bug reported in id:87mwpiu4vi.fsf@zancas.localnet
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2013-07-19 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:51E95500.8000404@fifthhorseman.net>
2013-07-19 15:36 ` [PATCH] crypto: return NULL cryptoctx if protocol string is empty Jameson Graef Rollins
2013-07-19 15:57 ` Jameson Graef Rollins [this message]
2013-07-20 12:36 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwpi8run.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).