unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/8] Improve tag change completion
Date: Tue, 22 Oct 2013 22:43:53 +0100	[thread overview]
Message-ID: <87mwm1x9pi.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu>


This looks good to me +1. It makes the code clearer and nicer to read as
well as giving a better user experience, and it is makes fixing the long
standing tagging races simpler.

I have a couple of docstring comments:

In patch 2 perhaps notmuch-tag-completions could have a docstring.

In Patch 4 I think the docstring for notmuch-search-tag is outdated: it
 is "Change tags for the currently selected thread or region." but 
 beg and end can now be specified by the caller.

and one actual comment:

in patch 3 (for show) delete-dups is called before the list is passed to
notmuch-read-tag-changes whereas it is not for search or pick.
Obviously this is not actually a problem but it might be worth being
consistent.

But that was all I found. All tests pass and everything I try behaves
exactly as expected.

Best wishes

Mark


On Tue, 22 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> This series improves tag change completion in various ways for
> commands like +, -, and *.
>
> From a user perspective, this provides command-specific prompts like
> "Tag message" and "Tag all" instead of the generic "Tag" prompt, and
> bases tag removal completions on the tags that are in the buffer,
> rather than the current tags in the database, providing a more
> predicable experience.
>
> From an implementation perspective, this new tag removal completion
> behavior improves efficiency and eliminates a road block to fixing the
> tagging race bug (which otherwise results in massive queries just to
> compute removal completions).  The new code is also more "Elispy" and
> predictable because all tag change prompting now occurs at the
> interactive entry points, rather than buried under several layers of
> non-interactive calls.
>
> This is a spiritual successor to
> id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com, though
> it takes a very different approach.  This is also a prerequisite to
> the tag race fix in
> id:1381185201-25197-1-git-send-email-amdragon@mit.edu and I plan to
> send an updated version of that series when this one is accepted.
>
> Patches 1, 5, and 6 could be pushed on their own.  They fix bugs or
> sort of bugs that get in the way of the rest of the series.
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2013-10-22 21:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 19:50 [PATCH 0/8] Improve tag change completion Austin Clements
2013-10-22 19:50 ` [PATCH 1/8] emacs: Fix misuse of `notmuch-tag' Austin Clements
2013-10-22 19:50 ` [PATCH 2/8] emacs: Take prompt and current tags in `notmuch-read-tag-changes' Austin Clements
2013-10-22 19:50 ` [PATCH 3/8] emacs: Use interactive specifications for tag changes in show Austin Clements
2013-10-22 19:50 ` [PATCH 4/8] emacs: Use interactive specifications for tag changes in search Austin Clements
2013-10-22 19:50 ` [PATCH 5/8] pick: Fix incorrect use of `notmuch-pick-tag' Austin Clements
2013-10-22 19:50 ` [PATCH 6/8] pick: Use list form of tag-changes in test Austin Clements
2013-10-22 19:50 ` [PATCH 7/8] pick: Use interactive specifications for tag changes Austin Clements
2013-10-22 19:50 ` [PATCH 8/8] emacs: Remove interactive behavior of `notmuch-tag' Austin Clements
2013-11-04  0:42   ` Jameson Graef Rollins
2013-11-12 23:18     ` Austin Clements
2013-10-22 21:43 ` Mark Walters [this message]
2013-10-23  0:19   ` [PATCH 0/8] Improve tag change completion Austin Clements
2013-10-23  9:56     ` Mark Walters
2013-10-23 15:44       ` Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwm1x9pi.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).