From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: precedence in `notmuch-search-line-faces'
Date: Sun, 04 May 2014 08:31:59 +0100 [thread overview]
Message-ID: <87mwey3spc.fsf@qmul.ac.uk> (raw)
In-Reply-To: <cunmwf0h1q7.fsf@hotblack-desiato.hh.sledj.net>
I have a slight preference for making it do the comment (ie reverse the
list). My reason is that we have some other cases such as
notmuch-tag-format that apply the first match, so users might be used to
having the specific first and the more general later.
It also has a small advantage of being less disruptive but, given that I
don't think any of us realised it changed, I guess most people aren't
using multiple matches.
Best wishes
Mark
On Fri, 02 May 2014, David Edmondson <dme@dme.org> wrote:
> The documentation for `notmuch-search-line-faces' says:
>
>> The attributes defined for matching tags are merged, with later
>> attributes overriding earlier.
>
> A comment in `notmuch-search-color-line', which implements this, says:
>
>> ;; Reverse the list so earlier entries take precedence
>
> Clearly these two are at odds. The implementation of
> `notmuch-search-color-line' follows the comment. That is, earlier
> entries in the list take precedence.
>
> The original implementation of `notmuch-search-color-line' followed the
> documentation of the user-visible variable, but this was changed by
> commit 60ebc849 in July 2012.
>
> I'm inclined to go with the documentation and change the implementation,
> but this could obviously ruin things for some users until they reorder
> their settings.
>
> Thoughts?
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-05-04 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 11:14 precedence in `notmuch-search-line-faces' David Edmondson
2014-05-04 7:31 ` Mark Walters [this message]
2014-05-06 9:40 ` David Edmondson
2014-05-06 9:42 ` [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces' David Edmondson
2014-05-06 10:03 ` David Edmondson
2014-05-06 10:09 ` David Edmondson
2014-05-06 18:33 ` Tomi Ollila
2014-05-06 18:52 ` Mark Walters
2014-05-17 21:47 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwey3spc.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).