From: Jani Nikula <jani@nikula.org>
To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 2/2] test: Add test for correct naming of author.
Date: Sat, 22 Nov 2014 13:31:04 +0200 [thread overview]
Message-ID: <87mw7jqxon.fsf@nikula.org> (raw)
In-Reply-To: <1416585462-24558-3-git-send-email-jrosenthal@jhu.edu>
On Fri, 21 Nov 2014, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> This is a new test file, since handling of unusual email addresses
> doesn't seem to fit well in any of our existing tests.
It would be nice to have this as patch 1/2 annotated with "known broken"
and have the implementation patch fix it. It's nice to see that the
patch actually changes things! ;)
BR,
Jani.
>
> Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
> ---
> test/T205-author-naming.sh | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100755 test/T205-author-naming.sh
>
> diff --git a/test/T205-author-naming.sh b/test/T205-author-naming.sh
> new file mode 100755
> index 0000000..cb678ae
> --- /dev/null
> +++ b/test/T205-author-naming.sh
> @@ -0,0 +1,12 @@
> +#!/usr/bin/env bash
> +test_description="naming of authors with unusual addresses"
> +. ./test-lib.sh
> +
> +test_begin_subtest "Add author with empty quoted real name"
> +add_message '[subject]="author-naming: Initial thread subject"' \
> + '[date]="Fri, 05 Jan 2001 15:43:56 -0000"' \
> + '[from]="\"\" <address@example.com>"'
> +output=$(notmuch search --sort=oldest-first author-naming and tag:inbox | notmuch_search_sanitize)
> +test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] address@example.com; author-naming: Initial thread subject (inbox unread)"
> +
> +test_done
> --
> 2.1.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2014-11-22 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 15:57 [PATCH v2 0/2] Use email address instead of empty real name Jesse Rosenthal
2014-11-21 15:57 ` [PATCH v2 1/2] lib: " Jesse Rosenthal
2014-11-22 11:29 ` Jani Nikula
2014-11-21 15:57 ` [PATCH v2 2/2] test: Add test for correct naming of author Jesse Rosenthal
2014-11-22 11:31 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw7jqxon.fsf@nikula.org \
--to=jani@nikula.org \
--cc=jrosenthal@jhu.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).