From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1FFA86DE0E43 for ; Sat, 10 Sep 2016 15:52:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OC02NEFTS1cw for ; Sat, 10 Sep 2016 15:52:01 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 8EB2F6DE0BF6 for ; Sat, 10 Sep 2016 15:52:01 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1bir7p-0000jP-KA; Sat, 10 Sep 2016 18:51:53 -0400 Received: (nullmailer pid 3750 invoked by uid 1000); Sat, 10 Sep 2016 22:51:58 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v2 12/14] cli/reply: pass internet address list to munge detect In-Reply-To: <2bdf4c7e53829fed525671f9f8f874323737f814.1471088022.git.jani@nikula.org> References: <2bdf4c7e53829fed525671f9f8f874323737f814.1471088022.git.jani@nikula.org> User-Agent: Notmuch/0.22.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sat, 10 Sep 2016 19:51:58 -0300 Message-ID: <87mvjfz7u9.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 22:52:02 -0000 Jani Nikula writes: > --- > notmuch-reply.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) The commit message needs a bit more explanation. I think the writer knows this code too well ;). - This changes the arguments of reply_to_header_is redundant, - "munge detect" is really only defined by a careful reading of comments.