From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 8F8756DE12C3 for ; Mon, 10 Oct 2016 06:28:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.311 X-Spam-Level: X-Spam-Status: No, score=0.311 tagged_above=-999 required=5 tests=[AWL=0.332, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bd6Z5ODXG0GA for ; Mon, 10 Oct 2016 06:28:51 -0700 (PDT) Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by arlo.cworth.org (Postfix) with ESMTPS id 45DB86DE12C1 for ; Mon, 10 Oct 2016 06:28:51 -0700 (PDT) Received: by mail-qk0-f194.google.com with SMTP id n66so6817935qkf.0 for ; Mon, 10 Oct 2016 06:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adirat-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=OB2jP/Jtip5/Evp9L5nHZSP7zT6ikqPVibuCBx1/Y7w=; b=XuVmDAKIc9cqgDOUfQ+tatfrh1z/c7zQMyXazUPd9CArW5xb9PVoCq9FZbEvAkQsUF 3HtLnAA+k9SdeVO8HkUqGIsPwdouufOLMgKQadzhO8VZs0zT0igrBQj7b45B3rm0E1UG D+d1GibGCeRZ7xONNL9SuZO8qmXlprz+0fNom3UsC4JSOvp09hfawesoSPxpKwontRTE FNOeeET9jXc5NSm518ejUzhkreRplglEHUd9qL+C8lqOAID9K7u9AgN1HiqTLi5dllHx wTINIVkigLkJs9cX6UGAub7rOyOkg9/Vp68bkOryNZNsx2RrhPK4sqGP/vmtJsvyciA5 yzzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=OB2jP/Jtip5/Evp9L5nHZSP7zT6ikqPVibuCBx1/Y7w=; b=Jk6kcikQ00/oPylIPKOY7Ye39mAOeBO6uGYr1FpAJaURAfe5tiS0MSR6v6QbFg9Qxe rtI+AwrlHmHa0c4eVIb3kFrvtOG6FrB03WcnmIIcfoiFRMjGs5jUBwm5H1vGMhT9CBYX 3XG3hD1KjwkEmcDD4KN9W2JsqYLPJoUWpFf0f/jHrN9oJ05QxzG6aAQHcTIjQAjjWEza uduTU+/C2ooIoTfxOge5HdxgUt+rf9AxzG2z0npIDu9RgrfkpBB3hc8f/DL0IJcF7XLG 0vfXZg4gd6Zv/cSGpyEUNDlIeSmKwRQuGlf1XAcWcbFbbQwY/Pkumac7N5tEDGZV5AfJ /FHA== X-Gm-Message-State: AA6/9RnsScxedSqSN/bNAhnMsZm3Y12i4CCPlw/L47WT1Gc+gbxvcxKf8Z2vt5Ni+feSag== X-Received: by 10.194.142.116 with SMTP id rv20mr31103014wjb.184.1476106129812; Mon, 10 Oct 2016 06:28:49 -0700 (PDT) Received: from adi-pc-linux ([80.97.64.55]) by smtp.gmail.com with ESMTPSA id p3sm40034981wjr.31.2016.10.10.06.28.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Oct 2016 06:28:49 -0700 (PDT) From: Ioan-Adrian Ratiu To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v5 0/7] Add refresh all buffers functionality In-Reply-To: <1476045223-5238-1-git-send-email-markwalters1009@gmail.com> References: <1476045223-5238-1-git-send-email-markwalters1009@gmail.com> Date: Mon, 10 Oct 2016 16:27:13 +0300 Message-ID: <87mvicibbi.fsf@adi-pc-linux.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 13:28:52 -0000 On Sun, 09 Oct 2016, Mark Walters wrote: > This is a simplified version of the series at > id:20161008210139.25322-1-adi@adirat.com > > The main change is that it makes all the refresh functions refresh the > buffer without forcing the buffer to be displayed. > > In tree and show mode this was already the case; in search mode it is > a change but since the refresh function has to be called in the buffer > it is likely to already be displayed. In hello mode it a genuine > change, but notmuch-hello-update is a trivial wrapped of notmuch-hello > so anyone who wants to force display can just call notmuch-hello. > > Once this change is made Ionel's changes become very clean. LGTM. I had a few minutes to apply and test this series and all my use-cases work perfectly. Thank you for helping with this. > > Best wishes > > Mark > > > Ioan-Adrian Ratiu (4): > emacs: notmuch-search: add no-display functionality > emacs: notmuch-search-refresh-view: reuse buffer > emacs: notmuch-show: refresh all windows displaying buffer > emacs: notmuch-lib: add refresh all buffers function > > Mark Walters (3): > emacs: tree: make refresh use generic binding > emacs: make the refresh functions more consistent > emacs: hello: stop update from forcing the buffer to be displayed > > emacs/notmuch-hello.el | 7 ++++--- > emacs/notmuch-lib.el | 23 ++++++++++++++++++----- > emacs/notmuch-show.el | 19 +++++++++++++------ > emacs/notmuch-tree.el | 1 - > emacs/notmuch.el | 16 +++++++++++----- > 5 files changed, 46 insertions(+), 20 deletions(-) > > -- > 2.1.4