From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E39C26DE0159 for ; Sat, 5 Nov 2016 05:20:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 1.188 X-Spam-Level: * X-Spam-Status: No, score=1.188 tagged_above=-999 required=5 tests=[AWL=1.058, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g350MUlM4QqH for ; Sat, 5 Nov 2016 05:20:25 -0700 (PDT) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by arlo.cworth.org (Postfix) with ESMTPS id B0E986DE00D3 for ; Sat, 5 Nov 2016 05:20:23 -0700 (PDT) Received: by mail-wm0-f48.google.com with SMTP id c184so17288085wmd.0 for ; Sat, 05 Nov 2016 05:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=mRV74iUyqaUC7/yOA9lJz7+d/aEtTTNEmBZ109B2Tt8=; b=qom6D1PT0baPN4JJzeaajhTHAEN27dYaYjt/Be5sCraEdVefvelDZtdatdTsq9ezdm dWYIs//ofUtPZdfUuW7aD1zvTBg4n3NnkhXnDZRa/OjjzprWpfuAkzc37+mBDwlKR9LD 1A2potn22EvAAD0jSJ+RZBCd7USIPHGeYi2z4mnzO0D+c6GTZzi21zCpmQ2NEx3H9hCH 8v8iVg2qq7iqiDOK4gcxxYEN6kA5JH+hgrtiQIvkcHkCFhmiJbkm1iJzoaUuCVfsGiUu fP/IVp7+9fJy/qyHsaYwskRuF+cvbeFtVt3y7jgpO361pm44p0FAGDhg3HQBYuEBCls8 v9Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=mRV74iUyqaUC7/yOA9lJz7+d/aEtTTNEmBZ109B2Tt8=; b=VvOHig+1mLvQO2y/Sq/pdGPCZTKND05cSUDLFIDATcySoH4hvvXXN7uo1echJKTuIK Mik618sYz81IsbCeSbRTjAeD1fg6cWnd7bQQvjHniIX0UFPvvcK7h2rLORibTdkPEtgV PPqVqB83rh9xGVZ+neggxGnKDSYCo7+Txny0GEVXnkPHViSpHpd1BfPH0+uA/F3AC5uC uwmSDAFQ4X8DiwdGNuyqJI64x6LJlmmCx5kYhxd8PQzSnAIcRHAik1aqVG4lEI02sN3l BF70zxVUCJRdB3kr0ullMEGsJsVE5BUpxN9u5zQYwM5J1+G4URrGTb+/ViwLzcvyKS1i iXQQ== X-Gm-Message-State: ABUngvfmDXw0eWmMFG2WhaA7ux7uvUGP1kyQxZoce94JsGnUAjLSHK5g0SuZa2B+J0BRBg== X-Received: by 10.28.71.14 with SMTP id u14mr1670953wma.10.1478348420989; Sat, 05 Nov 2016 05:20:20 -0700 (PDT) Received: from localhost (92.41.24.77.threembb.co.uk. [92.41.24.77]) by smtp.gmail.com with ESMTPSA id g6sm19441890wjp.45.2016.11.05.05.20.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Nov 2016 05:20:20 -0700 (PDT) From: Mark Walters To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: add check for encryption before saving. In-Reply-To: <87twbmfbuo.fsf@tethera.net> References: <1478196548-19596-3-git-send-email-markwalters1009@gmail.com> <20161105012902.26704-1-david@tethera.net> <87poma5mpg.fsf@qmul.ac.uk> <87twbmfbuo.fsf@tethera.net> Date: Sat, 05 Nov 2016 12:20:18 +0000 Message-ID: <87mvhe5da5.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2016 12:20:27 -0000 On Sat, 05 Nov 2016, David Bremner wrote: > Mark Walters writes: > >> >> I think this is an excellent thing to add. I agree that false positives >> aren't much of a worry. If someone bumps into them a lot then they can >> complain or come up with a better regex. >> > > Should the regex also be a defcustom? I think not a defcustom, but perhaps a defvar (the difference being that defvar's are hidden from most users -- anyone who can write a better regex can use setq in their init file). I think even if we don't expect users to change it making it a defvar is quite clean so that might be best. Best wishes Mark