From: Marius Bakke <mbakke@fastmail.com>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, notmuch@notmuchmail.org
Subject: Re: T350 test failures with gnupg-2.1.16
Date: Wed, 23 Nov 2016 00:20:53 +0100 [thread overview]
Message-ID: <87mvgrnlt6.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87eg23i052.fsf@alice.fifthhorseman.net>
[-- Attachment #1: Type: text/plain, Size: 2288 bytes --]
Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> On Tue 2016-11-22 15:49:37 -0500, Daniel Kahn Gillmor wrote:
>> On Tue 2016-11-22 14:22:09 -0500, Marius Bakke wrote:
>>> T350-crypto: Testing PGP/MIME signature verification and decryption
>>> PASS emacs delivery of signed message
>>> FAIL signature verification
>>> --- T350-crypto.2.expected 2016-11-22 18:59:48.341851653 +0000
>>> +++ T350-crypto.2.output 2016-11-22 18:59:48.341851653 +0000
>>> @@ -11,7 +11,7 @@
>>> "id": 2
>>> },
>>> {
>>> - "content-length": 280,
>>> + "content-length": 312,
>>> "content-type": "application/pgp-signature",
>>> "id": 3
>>> }
>>
>> If you could get me a copy of the actual application/pgp-signature part,
>> i'd be interested in looking at it. Unlike bremner, i'm actually able
>> to duplicate this problem on debian sid, so i'll see what i can figure
>> out.
>
> OK, the difference here is that 2.1.16 is automatically including the
> full OpenPGP v4 fingerprint in the message signature. This is part of
> the ongoing discussion around revisions to the OpenPGP standard, and it
> makes it easier for a mail user agent to tell whether it's missing the
> key for verification or whether the signature is just bad.
>
> so the length of the signature is extended by about 23 octets (1 octet
> of subpacket length; 1 octet of subpacket type, 1 octet of fpr versio
> number, and 20-octets of fingerprint), which becomes about 32 octets
> after base64 encoding, hence the increase in content-length from 280 to
> 312 octets.
>
> As for how to fix it -- i guess the right thing would be to make that
> number variable -- as long as the signature is non-zero and it
> validates, i think it'd be fine.
Wow, good catch. I was about to bisect gnupg to figure out what changed
this behaviour..
I'm not familiar enough with the notmuch test framework to suggest a
fix, but glad to know this is not specific to Guix.
Thanks a lot for your help!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2016-11-22 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 19:22 T350 test failures with gnupg-2.1.16 Marius Bakke
2016-11-22 19:59 ` David Bremner
2016-11-22 20:12 ` Marius Bakke
2016-11-22 20:36 ` David Bremner
2016-11-22 21:20 ` Marius Bakke
2016-11-22 20:49 ` Daniel Kahn Gillmor
2016-11-22 23:07 ` Daniel Kahn Gillmor
2016-11-22 23:20 ` Marius Bakke [this message]
2016-11-23 16:41 ` [PATCH] tests: account for varying-size OpenPGP signatures Daniel Kahn Gillmor
2016-11-23 16:59 ` David Bremner
2016-11-23 17:58 ` Daniel Kahn Gillmor
2016-11-23 17:57 ` [PATCH v2] tests: account for varying-size cryptographic signatures Daniel Kahn Gillmor
2016-11-25 1:27 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvgrnlt6.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).