From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E26D66DE0314 for ; Tue, 12 Sep 2017 09:26:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.053 X-Spam-Level: X-Spam-Status: No, score=-0.053 tagged_above=-999 required=5 tests=[AWL=-0.053] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7b87aA1qT8xR for ; Tue, 12 Sep 2017 09:26:31 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id 1F5AA6DE02DA for ; Tue, 12 Sep 2017 09:26:31 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id 2C446F99A; Tue, 12 Sep 2017 12:26:29 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 7EA42208A0; Tue, 12 Sep 2017 12:07:49 -0400 (EDT) From: Daniel Kahn Gillmor To: Gaute Hope , notmuch@notmuchmail.org Subject: Re: [PATCH v2] python: deprecated add_message calls index_file correctly and returns result In-Reply-To: <20170830081633.17616-1-eg@gaute.vetsj.com> References: <20170828073923.31442-1-eg@gaute.vetsj.com> <20170830081633.17616-1-eg@gaute.vetsj.com> Date: Tue, 12 Sep 2017 12:07:49 -0400 Message-ID: <87mv5zzyqy.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 16:26:32 -0000 On Wed 2017-08-30 10:16:33 +0200, Gaute Hope wrote: > The deprecated Database.add_message now calls the new index_file with > correct number of arguments (without an extra `self`), and returns the > tuple from index_file - as it used to do before. > > This change also adds a DeprecationWarning to the function. lgtm. thanks for fixing my bugs, Gaute. --dkg