From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0CDAD6DE0A9A for ; Sat, 21 Oct 2017 08:02:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dndmAiNMNPGs for ; Sat, 21 Oct 2017 08:02:30 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id ED43C6DE0318 for ; Sat, 21 Oct 2017 08:02:29 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1e5vEL-0008Ew-B7; Sat, 21 Oct 2017 10:58:29 -0400 Received: (nullmailer pid 4193 invoked by uid 1000); Sat, 21 Oct 2017 15:02:24 -0000 From: David Bremner To: Jani Nikula , Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup In-Reply-To: <20171021115802.31197-1-jani@nikula.org> References: <878tg59qmw.fsf@tethera.net> <20171021115802.31197-1-jani@nikula.org> Date: Sat, 21 Oct 2017 12:02:24 -0300 Message-ID: <87mv4k8ry7.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2017 15:02:31 -0000 Jani Nikula writes: > The primary motivation here is to fix TMP_DIRECTORY cleanup prior to > running each test when the current working directory is not the test > subdirectory. Tests with failures would leave their TMP_DIRECTORY > directory behind for debugging, and repeated out-of-tree test runs > would have old temp directories. (This lead to e.g. T310-emacs.sh > hanging because emacs would prompt for overwriting files.) > > We remove the likely anyway defunct --root test option while at it, > just to be on the safe side when doing 'rm -rf' on the TMP_DIRECTORY. This seems to fix the problem I reported, however applying id:cd03efa9c93ee54f7e7f7e166079062984ddd658.1506370901.git.jani@nikula.org on top breaks ./devel/check-out-of-tree-build.sh test I get lots of errors along the lines of Error opening database at /tmp/tmp.GD3HPpejbL/test/tmp.T350-crypto/mail/.notmuch: No such file or directory So this patch seems to unbreak in-tree builds (and out of tree builds where we copy the whole test hierarchy), and is probably worth applying as is, but I wanted to give you a chance to respond before I proceed. d