[PATCH] test: avoid unnecessary extraction of the test fingerprint

[PATCH] test: avoid unnecessary extraction of the test fingerprint

[Daniel Kahn Gillmor]

FINGERPRINT is already exported by add_gnupg_home, so this is
unnecessary.  This change also happens to get rid of the superfluous
check-trustdb spew from the test suite that looked like this:

gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 test/T357-index-decryption.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh
index c9cd5e30..8a2d4c02 100755
--- a/test/T357-index-decryption.sh
+++ b/test/T357-index-decryption.sh
@@ -8,8 +8,6 @@ test_description='indexing decrypted mail'
 ##################################################
 
 add_gnupg_home
-# get key fingerprint
-FINGERPRINT=$(gpg --no-tty --list-secret-keys --with-colons --fingerprint | grep '^fpr:' | cut -d: -f10)
 
 # create a test encrypted message
 test_begin_subtest 'emacs delivery of encrypted message'
-- 
2.20.1

Re: [PATCH] test: avoid unnecessary extraction of the test fingerprint

[Tomi Ollila]

On Tue, May 07 2019, Daniel Kahn Gillmor wrote:

> FINGERPRINT is already exported by add_gnupg_home, so this is
> unnecessary.  This change also happens to get rid of the superfluous
> check-trustdb spew from the test suite that looked like this:
>
> gpg: checking the trustdb
> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

LGTM (just quick glance -- but code removal is always good thing when
possible ! ;)

(I trust dkg knows what he is doing in this matter)

Tomi

> ---
>  test/T357-index-decryption.sh | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh
> index c9cd5e30..8a2d4c02 100755
> --- a/test/T357-index-decryption.sh
> +++ b/test/T357-index-decryption.sh
> @@ -8,8 +8,6 @@ test_description='indexing decrypted mail'
>  ##################################################
>  
>  add_gnupg_home
> -# get key fingerprint
> -FINGERPRINT=$(gpg --no-tty --list-secret-keys --with-colons --fingerprint | grep '^fpr:' | cut -d: -f10)
>  
>  # create a test encrypted message
>  test_begin_subtest 'emacs delivery of encrypted message'
> -- 
> 2.20.1

Re: [PATCH] test: avoid unnecessary extraction of the test fingerprint

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> FINGERPRINT is already exported by add_gnupg_home, so this is
> unnecessary.  This change also happens to get rid of the superfluous
> check-trustdb spew from the test suite that looked like this:
>
> gpg: checking the trustdb
> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u

merged to master. That does indeed quiet down the noise I complained
about.

d