From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QAPDA3nBmmDPEQEAgWs5BA (envelope-from ) for ; Tue, 11 May 2021 19:40:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4Gv2OnjBmmC8PwAA1q6Kng (envelope-from ) for ; Tue, 11 May 2021 17:40:08 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5B2F11888 for ; Tue, 11 May 2021 19:40:08 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2BBE52717B; Tue, 11 May 2021 13:40:05 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 43D622717A for ; Tue, 11 May 2021 13:40:01 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id A698060016; Tue, 11 May 2021 13:39:59 -0400 (EDT) Received: (nullmailer pid 779868 invoked by uid 1000); Tue, 11 May 2021 17:39:58 -0000 From: David Bremner To: Michael J Gruber , Alexander Adolf , notmuch@notmuchmail.org Subject: Re: Possible threading issues in nm 0.32 In-Reply-To: <162075216869.247978.11973039285204032566.git@grubix.eu> References: <162020111427.14194.6147957596067303106.git@grubix.eu> <87lf8tl5xp.fsf@tethera.net> <162048871025.4412.16478596244616302794.git@grubix.eu> <17c04a657363f96fac1c477f238b96d6@condition-alpha.com> <9a30dccb8d00c3de861abb3057331949@condition-alpha.com> <162074768557.189534.10699410442728726615.git@grubix.eu> <162075216869.247978.11973039285204032566.git@grubix.eu> Date: Tue, 11 May 2021 14:39:58 -0300 Message-ID: <87mtt1goep.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: GNZ4HOKRGSYKAGMHCWTAOJHX43LVNRAF X-Message-ID-Hash: GNZ4HOKRGSYKAGMHCWTAOJHX43LVNRAF X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620754808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=d1OoLMI0ZN+8NGZZ1o+vMKe7CQhwvNETvv0cc9SI9+U=; b=T+BMblh2qCI5jr/jthfusVd9ESBCFcMa7bshcLvmpGMd5mnMVlDoPHQsggr+7Yexe3rv4D Ub8qNKANMErbHMQQrHahRN2niGq4SG9rxXHtamaHpLkfFfl3xhfAy6HTe1iQFL3E5IK2wv 1QkUqHhPm5Vd41UsnWUWc3bR7+vxbnKpn0ht1bqMTvEM+Dhiu/xOxGz7k6xS6eRLPEyu3+ 4Z9BtTX0TOsC16vrnsrBl8Eks9hrpYFLsi6p2phSICLPMBmei6cZFktumEKFRk2aItId6V aaacvN8cnHmzEM49tgbOagJa2XsTyGSdNl8rRLhkRuxB/OaMhj6t1l+HEVL1uw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620754808; a=rsa-sha256; cv=none; b=aETCxIpqZTiMtckW4UlwE3lXb8+s90uuC6xiFRnrIxaCkPv+FtTQu210Z5FJ2UuRk+h2GV HXD8HlBCnO4QXMNZAg9j6NqcenRw9HxpIRZrZnGVMVE247qUePvzprkjDjLLM4UblNHxU4 GvrUh6iNYwwa+R2IIhwYg8EAjP6UD72v3vRHsup2OO5q0ZGKH+lSSM3swNsoPVRvHqur5A G+ci19FX86pRp81veH3R0VzLa8Kkh5Jb4XmeoYuLN9Q8Kg9GSITFrfSFjF13/dpfWYPNDK YaDZ3Pxc2fAhLWzT4OYzk98oI68a3Z9kLEikI6fwHrZQmz6xPdXUnlLWkp/OAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.56 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B5B2F11888 X-Spam-Score: -0.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: cEMXqm+zONm4 Michael J Gruber writes: > ... just a guess: Could it be that > > a9f74aee ("CLI/new: drop the write lock to run the pre-new hook.", 2021-03-18) > > was not enough? > > notmuch_database_reopen() only reopens the xapian db but does not update > other members in notmuch_database_t *notmuch, such as the last doc id > and thread id. That sounds plausible. By happy coincidence I prepared a patch for this on the weekend as part of a different series. I will send the patch as a followup. It would be nice to have a regression test for this, but I'm not sure how easy it is to reproduce deterministically. d