unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Alan Schmitt <alan.schmitt@polytechnique.org>,
	notmuch <notmuch@notmuchmail.org>
Subject: Re: performance in emacs displaying a huge thread
Date: Wed, 22 Sep 2021 22:48:13 -0300	[thread overview]
Message-ID: <87mto4awpu.fsf@tethera.net> (raw)
In-Reply-To: <87ilytvrb4.fsf@m4x.org>

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

>
> I can view a thread with more than 7000 messages (with
> show-only-matching-messages to t) if they are not encrypted. In fact I
> already could with 0.32 if I remember correctly. The fact that messages
> are encrypted seems to matter here.

I've been unable to replicate this deep recursion. Whenever I'm in
unthreaded search view, I have one message summary on every line, and
when I trace through notmuch-show-insert-tree,

  (let ((msg (car tree))
	(replies (cadr tree)))

always assigns nil (empty list) to replies.  That means my call stack
has exactly one instance of notmuch-show-insert-tree.

>
> If it matters, here is the bottom of the debug stack:
>
>   notmuch-show-insert-thread(((nil ((nil ((nil nil) (nil (... ...))))))) 1)
>   notmuch-show-insert-tree((nil ((nil ((nil ((nil nil) (nil ...))))))) 0)
>   #f(compiled-function (tree) #<bytecode 0x155b49d5fc55>)((nil ((nil ((nil ((nil nil) (nil ...))))))))
>   mapc(#f(compiled-function (tree) #<bytecode 0x155b49d5fc55>) ((nil ((nil ((nil (... ...))))))))
>   notmuch-show-insert-thread(((nil ((nil ((nil (... ...))))))) 0)
>   #f(compiled-function (thread) #<bytecode 0x155b49b2e195>)(((nil ((nil ((nil (... ...))))))))
>   mapc(#f(compiled-function (thread) #<bytecode 0x155b49b2e195>) (((nil ((nil ((nil ...))))))))
>   notmuch-show-insert-forest((((nil ((nil ((nil ...))))))))
>   notmuch-show--build-buffer()
>   notmuch-show("id:Mr.ye1AxFHsd2E.Vd_oS17awSv@polytechnique.org")
>   notmuch-tree-show-message-out()
>   notmuch-tree-show-message(nil)
>   funcall-interactively(notmuch-tree-show-message nil)
>   call-interactively(notmuch-tree-show-message nil nil)
>   command-execute(notmuch-tree-show-message)

On possibility is that there some old version of the code that you are
running.  Inside notmuch-show-insert-tree, the variable
notmuch-show-single-message should be 't', whether called from regular
tree-mode or an unthreaded search.

As an experiment, you could try redefining

(defun notmuch-show-insert-tree (tree depth)
  "Insert the message tree TREE at depth DEPTH in the current thread."
  (let ((msg (car tree))
	(replies (cadr tree)))
    (message "nreplies %d flag %s" (length replies) notmuch-show-single-message)
    ;; We test whether there is a message or just some replies.
    (when msg
      (notmuch-show-insert-msg msg depth))
    (notmuch-show-insert-thread replies (1+ depth))))

this will log the number of replies and flag value. For me, it logs

"nreplies 0 flag t"

  reply	other threads:[~2021-09-23  1:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 18:20 performance in emacs displaying a huge thread Alan Schmitt
2020-01-15 20:15 ` Örjan Ekeberg
2020-01-16  7:30   ` Alan Schmitt
2020-02-15 10:26   ` Alan Schmitt
2021-08-02  2:11     ` David Bremner
2021-08-20  7:43       ` Alan Schmitt
2021-08-20 16:55         ` David Bremner
2021-08-21  7:08           ` Alan Schmitt
2021-08-21 13:45             ` David Bremner
2021-09-21  7:59               ` Alan Schmitt
2021-09-21 12:42                 ` David Bremner
2021-09-21 14:24                   ` Alan Schmitt
2021-09-21 15:38                     ` David Bremner
2021-09-21 16:14                       ` Alan Schmitt
2021-09-23  1:48                         ` David Bremner [this message]
2021-09-24 14:04                           ` Alan Schmitt
2021-09-24 23:33                             ` David Bremner
2021-09-25  7:01                               ` Alan Schmitt
2021-09-25 13:26                                 ` David Bremner
2021-10-06  6:49                                   ` Alan Schmitt
2021-09-21 18:27                     ` Tomi Ollila
2021-09-22  6:13                       ` Alan Schmitt
2021-09-22  8:25                         ` Tomi Ollila
2021-09-22  9:41                           ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mto4awpu.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=alan.schmitt@polytechnique.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).