From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gAoyB0jYVGK2sAAAgWs5BA (envelope-from ) for ; Tue, 12 Apr 2022 03:39:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MOyTO0fYVGJ5ZQAAG6o9tA (envelope-from ) for ; Tue, 12 Apr 2022 03:39:19 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D2F5A8E9 for ; Tue, 12 Apr 2022 03:39:19 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C230A5F6DD; Tue, 12 Apr 2022 01:39:16 +0000 (UTC) Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) by mail.notmuchmail.org (Postfix) with ESMTPS id B2E2B5F5E3 for ; Tue, 12 Apr 2022 01:39:14 +0000 (UTC) Received: from fifthhorseman.net (cpe-76-167-129-203.san.res.rr.com [76.167.129.203]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id AA288F9B0; Mon, 11 Apr 2022 21:39:09 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 6225C2043C; Mon, 11 Apr 2022 14:53:59 -0700 (PDT) From: Daniel Kahn Gillmor To: Michael J Gruber Subject: Re: [PATCH 2/2] test/smime: fix signature verification test with newer gmime. In-Reply-To: References: <874k3pvrfq.fsf@tethera.net> <20220409123453.606391-1-david@tethera.net> <20220409123453.606391-2-david@tethera.net> <87r164mp7a.fsf@fifthhorseman.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH Date: Mon, 11 Apr 2022 14:53:58 -0700 Message-ID: <87mtgrmgll.fsf@fifthhorseman.net> MIME-Version: 1.0 Message-ID-Hash: U5SRKZ3O2KX6LTIUGGLHCJO2DTEI5VNP X-Message-ID-Hash: U5SRKZ3O2KX6LTIUGGLHCJO2DTEI5VNP X-MailFrom: dkg@debian.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============9150420324806158359==" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649727559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:autocrypt:autocrypt; bh=8AvrkFLwc6ywRTPe6+PVxXq4QO8aADolHzLmT4gD3/g=; b=Jged+TNkiXxD2tU0lyeY33iUESbYPhzOlhwRLRPYDVLrb2aifz9fVepKAki/RdGgDuhSx3 7b2BJN12oXxHbZFNOnzdQCSc5ByfeTcdsNK+mb4+chP7W+hD+suMStXGPIM9uHztRqq82g qTZl1/H0YyAvhPeA0QGOmBG1zpwH6ipX/ifOFy8LrngLkp2ilZGT2ke1IW81oErstwI3jc 9NhzNBxzpwDzEvFktWGoqlJANp4yrY/r9xxm95Kb+Z0VZS4/S0i9xxzNPW80cbOiT+P3gq AC2smU8nw/KCNd3cA/bMlNmFL7QZjNo71DXSgjcJiVIbSunYpH0/EATA9/c83Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649727559; a=rsa-sha256; cv=none; b=eetT2yAHFx0/NtKfvzvJHnF5OtiFR1EndQ9pS/fmg0D2ahQUvxYhoCS4O5GUQ8BejiIJoL Ks3EtAvPIIO2GW6b1amaw/fybAGZnCqgWqdeLeHRT/OGKZoCp17aSetgifLVnCgZyx/0bv sAXiOv1Q2PZpuIKEcTka92p17+QHpP2cz1y3iPwSYZdtXVHL14DwzAjBUftRYIjbqVk0v6 cln3rfHGjVIGviMRFZ/jOMVG8LhpWjxlwcYRokkFWqRWUugyeT5sYqHmQ/bHeGF4vGYorY aUo6VxbqiJOCTCv89Rhaahv9Am6MMtxqXQqg9usYvDjKAyHsxvv04jcUvsga5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -5.28 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7D2F5A8E9 X-Spam-Score: -5.28 X-Migadu-Scanner: scn0.migadu.com X-TUID: hM2fG5BnBRWu --===============9150420324806158359== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Mon 2022-04-11 10:44:47 +0200, Michael J Gruber wrote: > Just so that others don't have to be wondering, too: notmuch does not embed > gmime sources and does not reuse them. (It would be very wrong to do so.) > notmuch has a file `_check_gmime_cert.c` which is used for configure checks > and which David cleverly amended to check for the return format of > signature checks (when compiled against the libgmime3). Yep, this is what i meant. > If I read 2/2 correctly, though, then T355-smime does not adjust its > expected textual outcome to the results of the check, but rather marks the > test "known broken" if the signature check does not return the "new" > format. In other words: Unless you have a very new unpatched gmime, > T355-sime does not "really" do this subtest any more - it is happy as soon > as it fails for any reason. Exactly right. Thanks for taking the time to explain it all in clearer English than my rushed shorthand, Michael. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYlSjdwAKCRA+nXFzcd5W XHwRAP9J72OhpAH9U0AWAFxDCk2Vft1y7grW9m0azezQGJBI3AEAgyQZFbEFkqnS 7CdEmokGceguPsFExO6W5VGbFYTrcAA= =RTYE -----END PGP SIGNATURE----- --=-=-=-- --===============9150420324806158359== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============9150420324806158359==--