From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8MiQCzRIl2PFAwEAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 16:26:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iG9/CzRIl2OpegAAauVa8A (envelope-from ) for ; Mon, 12 Dec 2022 16:26:44 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95C653B853 for ; Mon, 12 Dec 2022 16:26:43 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id F2A6A5F393; Mon, 12 Dec 2022 15:26:40 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 3B0D45F377 for ; Mon, 12 Dec 2022 15:26:39 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 9BCCC5FB9E; Mon, 12 Dec 2022 10:26:37 -0500 (EST) Received: (nullmailer pid 3660377 invoked by uid 1000); Mon, 12 Dec 2022 15:26:36 -0000 Resent-To: notmuch@notmuchmail.org Resent-From: David Bremner Resent-Date: Mon, 12 Dec 2022 11:26:36 -0400 Resent-Message-ID: <87359khccz.fsf@tethera.net> X-Envelope-From: jao@gnu.org Mon Dec 12 10:22:18 2022 Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by fethera.tethera.net (Postfix) with ESMTPS id 27F955FB9C for ; Mon, 12 Dec 2022 10:22:18 -0500 (EST) Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4kdC-00073y-Bg; Mon, 12 Dec 2022 10:22:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=cDAKJhTrF+Z73hjFQFpH/hCNJkQ1FryflHh2fy2tTGY=; b=iDEcCaKrokU4PaZGig6l nVKVJuDxoApwTINyRuDHuhQiO/I53mkOKv83+obf474N19aqmY0OPu3wOGEBNH+SFAZ5KKW4CMz1/ 3FUhiHquCvuHn2mVgW0Un0jMGV211FxCmvxucFyMbnhZ4NhT8kI45W5TdtWoke1kl6LBzhtnzb8/A 0YXDhDsZXwfEjce6tQrKqiydop9bkQ8oVOa7bciVnncqA7A4Cf+QgsfB0olSk0sx9uYrP9sgpyVhZ 6dDbhWgrhZFsFtCAZk0haZyH3clJqCdgkjHJ9abkMBnDfVUKnsfkwV6rEN75RX9BrDB7KngWXq2HL 6Rf6LZrsjaEIsw==; Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247] helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4kdB-00020D-Vs; Mon, 12 Dec 2022 10:22:14 -0500 Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id ea964681; Mon, 12 Dec 2022 15:22:11 +0000 (UTC) From: "Jose A. Ortega Ruiz" To: David Bremner Subject: Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode In-Reply-To: <87bko8hh9z.fsf@tethera.net> (David Bremner's message of "Mon, 12 Dec 2022 09:40:24 -0400") References: <20221104235229.515204-1-jao@gnu.org> <20221104235229.515204-2-jao@gnu.org> <87v8mhhk83.fsf@tethera.net> <87ilih4tf5.fsf@mail.jao.io> <87bko8hh9z.fsf@tethera.net> User-Agent: Gnus/5.13 (Gnus v5.13) X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: Date: Mon, 12 Dec 2022 15:22:11 +0000 Message-ID: <87mt7sabq4.fsf@mail.jao.io> MIME-Version: 1.0 Message-ID-Hash: QDZRQ2ITUSLLAUOKQNPOS2RC4ULKZ3VP X-Message-ID-Hash: QDZRQ2ITUSLLAUOKQNPOS2RC4ULKZ3VP X-MailFrom: jao@gnu.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670858803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-owner:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dWlMDhL4OijvzFYcUtcan4ivbM9tGaNyAXkQZKVVPXU=; b=nvVo3mfR4FMztDE8zUL4JwT6OEnnBkt/7E6ZJOUUcJVq50yID6eDxD+3WPgutr9jwIHHiM hJpeH0htzqm8CENMc2poUcJIF3DLk4Lcsq5Ug3QG6spLlFnX2wZIluRo96FklR62oS0fAt 6Z3PIhwfl3ll6d3u3YedpUOV4y2sTyO4sBda7OFDPmKb9nIvcUTyoudUvaFHoaAV24HpXf PhvZNiohPWJF23sqB8pY7xXuoxwesyadYb90Qf9zDawBebCfYcTXrAHSnCeemA9vAEQ0Sw f3aNMphUb5YTTZr/1f9lQy9mi0Fpz0oh+5ewpQPCCiFWvkiLMpSbYgBqaO6B8w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=iDEcCaKr; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670858803; a=rsa-sha256; cv=none; b=CYdxWpE0pPlrEpL3MRdM0NLq+9NKwUUGdfyjXymL0ynevhX1WT37enBWqMlXBP25s2oKOR lJqquXHou+FmKJkHFbMap8wqbI5t+DwNC0TQcnsFr7/6hAAOIcqyZlstCBg6Cdrz//7pT3 qJb0al1AEj8fd5zevAoHTCbKEbIjtuwHScw/9Dkno6DtWFpCrQX2X22t1rPKbGsNcdRC3i p89cS3og5YupZYEYXDC3L8rYwZbpA9gBms0HCrpCM8x7zeXgI5fkuF5M7P1zP5RNaoaraA mD0g/WrqP6sp4PMosQvGSBTzP2NHWqpzeVjPCLf0RAYE9xpcqLx7Gk0FQSnfaw== X-Migadu-Spam-Score: -0.99 X-Spam-Score: -0.99 X-Migadu-Queue-Id: 95C653B853 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gnu.org header.s=fencepost-gnu-org header.b=iDEcCaKr; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gnu.org (policy=none) X-TUID: LnAMKbZHXbtM On Mon, Dec 12 2022, David Bremner wrote: > jao writes: >>> >>> As mentioned in my previous reply, I'm still not 100% clear on why we >>> need both depth and level. >> >> i might be misremembering, but i think depth is just an auxiliarly >> argument taken by that function to know whether it's inserting the tip >> of a tree or not, not a real depth. level is. so a better way would be >> to make 'depth' take the values 'level' is currently taking, but i >> wasn't sure other code would be using depth with its old original >> meaning (e.g. via and advice; i did at some point). >> > > depth is used for indentation in notmuch-show-mode, so it should be > (close to) what you want? There is already a function > notmuch-show-get-depth. that doesn't work in notmuch-tree buffers, which is where it's needed. :depth is not even recorded as a message property there. we can simply rename :level to :depth as the new property there (although there's an off-by-one difference in their values sometimes for implementation details): since this will be in fact a brand new property in the notmuch-tree buffer anyway, that shouldn't cause any trouble, right?