* [PATCH] Make addresses case insensitive for the purpose of constructing replies.
@ 2009-11-23 18:29 Jed Brown
2009-11-24 2:35 ` Carl Worth
0 siblings, 1 reply; 2+ messages in thread
From: Jed Brown @ 2009-11-23 18:29 UTC (permalink / raw)
To: notmuch
The domain is alway case insensitive, but in principle the username is
case sensitive. Few systems actually enforce this so I think a good
default is to treat the entire address as case insensitive, it will
eliminate a lot of superfluous self-addressed messages and reply from
the correct address in these cases.
Signed-off-by: Jed Brown <jed@59A2.org>
---
notmuch-reply.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index 44e1766..cd81e76 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -97,12 +97,12 @@ address_is_users (const char *address, notmuch_config_t *config)
size_t i, other_len;
primary = notmuch_config_get_user_primary_email (config);
- if (strcmp (primary, address) == 0)
+ if (strcasecmp (primary, address) == 0)
return 1;
other = notmuch_config_get_user_other_email (config, &other_len);
for (i = 0; i < other_len; i++)
- if (strcmp (other[i], address) == 0)
+ if (strcasecmp (other[i], address) == 0)
return 1;
return 0;
--
1.6.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Make addresses case insensitive for the purpose of constructing replies.
2009-11-23 18:29 [PATCH] Make addresses case insensitive for the purpose of constructing replies Jed Brown
@ 2009-11-24 2:35 ` Carl Worth
0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2009-11-24 2:35 UTC (permalink / raw)
To: Jed Brown, notmuch
On Mon, 23 Nov 2009 19:29:52 +0100, Jed Brown <jed@59A2.org> wrote:
> The domain is alway case insensitive, but in principle the username is
> case sensitive. Few systems actually enforce this so I think a good
> default is to treat the entire address as case insensitive, it will
> eliminate a lot of superfluous self-addressed messages and reply from
> the correct address in these cases.
Good call. I've pushed this out now.
-Carl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-24 2:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-23 18:29 [PATCH] Make addresses case insensitive for the purpose of constructing replies Jed Brown
2009-11-24 2:35 ` Carl Worth
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).