From: James Westby <jw+debian@jameswestby.net>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: Missing messages breaking threads
Date: Fri, 18 Dec 2009 21:24:17 +0000 [thread overview]
Message-ID: <87ljh0rn5q.fsf@jameswestby.net> (raw)
In-Reply-To: <873a38ypg5.fsf@yoom.home.cworth.org>
On Fri, 18 Dec 2009 12:52:58 -0800, Carl Worth <cworth@cworth.org> wrote:
> On Fri, 18 Dec 2009 19:53:13 +0000, James Westby <jw+debian@jameswestby.net> wrote:
> Oh, I was assuming you wouldn't index any text. The UI can add "missing
> message" for a document with no filename, for example.
Works for me.
> > So, to summarise, I should first look at storing filesizes, then
> > the collision code to make it index further when the filesize grows,
> > and then finally the code to add documents for missing messages?
>
> Some of the code areas to be touched will be changing soon, (at least as
> far as when filenames appear and disappear). Hopefully I'll have
> something posted for that sooner rather than later to avoid having to
> redo too much work.
That would be great. I'm learning all the code anyway, so there's not
a whole lot of knowledge being thrown away.
I've just sent an initial cut at the fist step.
> > The only thing I am unclear on is how to handle existing databases?
> > Do we have any concept of versioning? Or should I just assume that
> > filesize: may not be in the document and act appropriately?
>
> My current, outstanding patch is going to be the first trigger for a
> "flag day" where we'll all need to rewrite our databases.
>
> We don't have any concept of versioning yet, but it would obviously be
> easy to have a new version document with an increasing integer.
>
> But even with my current patch I'm considering doing a graceful upgrade
> of the database in-place rather than making the user do something like a
> dump, delete, rebuild, restore. That would give a much better experience
> than "Your database is out-of-date, please rebuild it", so we'll see if
> I pursue that in the end.
That sounds nice, I'd certainly prefer this sort of thing as it evolves.
Thanks,
James
next prev parent reply other threads:[~2009-12-18 21:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 19:02 Missing messages breaking threads James Westby
2009-12-18 19:41 ` Carl Worth
2009-12-18 19:53 ` James Westby
2009-12-18 20:52 ` Carl Worth
2009-12-18 21:24 ` James Westby [this message]
2009-12-22 22:48 ` Olly Betts
2009-12-23 0:05 ` Carl Worth
2010-03-13 21:27 ` [PATCH] Store thread ids for messages that we haven't seen yet James Westby
2010-04-13 15:20 ` Carl Worth
2010-04-13 15:36 ` James Westby
2010-04-15 0:39 ` Carl Worth
2009-12-18 21:21 ` [PATCH] Store the size of the file for each message James Westby
2009-12-18 22:29 ` Carl Worth
2009-12-19 0:08 ` James Westby
2009-12-19 0:57 ` Carl Worth
2009-12-19 1:35 ` James Westby
2009-12-19 5:24 ` Carl Worth
2009-12-19 8:02 ` Marten Veldthuis
2009-12-19 17:17 ` Carl Worth
2009-12-19 13:12 ` [PATCH] Add ENVIRONMENT VARIABLES section to the man page James Westby
2010-02-23 19:25 ` Carl Worth
2009-12-19 0:11 ` [PATCH v2] Store the size of the file for each message James Westby
2009-12-19 1:29 ` [PATCH] Reindex larger files that duplicate ids we have James Westby
2009-12-21 18:33 ` Carl Worth
2009-12-20 20:27 ` [PATCH] Store documents for message-ids we haven't seen James Westby
2009-12-21 18:43 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljh0rn5q.fsf@jameswestby.net \
--to=jw+debian@jameswestby.net \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).