From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: notmuch@notmuchmail.org
Subject: [PATCH V3] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1 and V2)
Date: Tue, 23 Feb 2010 10:21:49 -0500 [thread overview]
Message-ID: <87ljekq8oi.fsf@jhu.edu> (raw)
In-Reply-To: <m1wryiayhg.fsf@watt.gilman.jhu.edu>
Change the buffer name to a uniquified subject of the thread (i.e. the
subject of the first message in the thread) instead of the thread-id. This
is more meaningful to the user, and will make it easier to scroll through
numerous open buffers.
Note that this patch adds an optional `buffer-name' argument to notmuch
show.
This version supersedes V1 and V2 of this patch. It is rebased on HEAD,
ensures that the buffer names are unique, and that the `notmuch-show'
command can still be used interactively (fixing a clumsy bug in V2 which
prevented that).
Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
---
notmuch.el | 21 +++++++++++++++++----
1 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/notmuch.el b/notmuch.el
index 6482170..685b2cd 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -1162,7 +1162,7 @@ All currently available key bindings:
(lambda()
(hl-line-mode 1) ))
-(defun notmuch-show (thread-id &optional parent-buffer query-context)
+(defun notmuch-show (thread-id &optional parent-buffer query-context buffer-name)
"Run \"notmuch show\" with the given thread ID and display results.
The optional PARENT-BUFFER is the notmuch-search buffer from
@@ -1172,7 +1172,10 @@ thread from that buffer can be show when done with this one).
The optional QUERY-CONTEXT is a notmuch search term. Only messages from the thread
matching this search term are shown if non-nil. "
(interactive "sNotmuch show: ")
- (let ((buffer (get-buffer-create (concat "*notmuch-show-" thread-id "*"))))
+ (when (null (buffer-name))
+ (setq buffer-name (concat "*notmuch-" thread-id "*")))
+ (let* ((thread-buffer-name (generate-new-buffer-name buffer-name))
+ (buffer (get-buffer-create thread-buffer-name)))
(switch-to-buffer buffer)
(notmuch-show-mode)
(set (make-local-variable 'notmuch-show-parent-buffer) parent-buffer)
@@ -1363,9 +1366,19 @@ Complete list of currently available key bindings:
(defun notmuch-search-show-thread ()
"Display the currently selected thread."
(interactive)
- (let ((thread-id (notmuch-search-find-thread-id)))
+ (let ((thread-id (notmuch-search-find-thread-id))
+ (subject (notmuch-search-find-subject))
+ buffer-name)
+ (when (string-match "^[ \t]*$" subject)
+ (setq subject "[No Subject]"))
+ (setq buffer-name (concat "*"
+ (truncate-string-to-width subject 32 nil nil t)
+ "*"))
(if (> (length thread-id) 0)
- (notmuch-show thread-id (current-buffer) notmuch-search-query-string)
+ (notmuch-show thread-id
+ (current-buffer)
+ notmuch-search-query-string
+ buffer-name)
(error "End of search results"))))
(defun notmuch-search-reply-to-thread ()
--
1.6.3.3
next prev parent reply other threads:[~2010-02-23 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 17:10 [PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id Jesse Rosenthal
2010-02-12 18:57 ` Jameson Rollins
2010-02-12 22:19 ` [PATCH v2] " Jesse Rosenthal
2010-02-15 7:52 ` Sebastian Spaeth
2010-02-23 15:21 ` Jesse Rosenthal [this message]
2010-03-06 14:20 ` [PATCH V4] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3) Jesse Rosenthal
2010-04-06 7:59 ` Sebastian Spaeth
2010-04-06 7:59 ` [PATCH] " Sebastian Spaeth
2010-04-07 17:46 ` [PATCH v2] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id Carl Worth
2010-04-09 14:01 ` Jesse Rosenthal
2010-04-09 23:23 ` Carl Worth
2010-04-10 13:48 ` Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljekq8oi.fsf@jhu.edu \
--to=jrosenthal@jhu.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).