From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 274964048C4 for ; Thu, 11 Mar 2010 08:22:58 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.26 X-Spam-Level: X-Spam-Status: No, score=-2.26 tagged_above=-999 required=5 tests=[AWL=0.339, BAYES_00=-2.599] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WviAiUl7pU5M for ; Thu, 11 Mar 2010 08:22:57 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id B79D24048C2 for ; Thu, 11 Mar 2010 08:22:56 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 432FF19F3431; Thu, 11 Mar 2010 17:22:43 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id aIiL2Xq-5ALz; Thu, 11 Mar 2010 17:22:41 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id DBC5319F3437; Thu, 11 Mar 2010 17:22:41 +0100 (CET) Received: from steelpick.localdomain (k335-30.felk.cvut.cz [147.32.86.30]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id C6374FA003; Thu, 11 Mar 2010 17:22:41 +0100 (CET) Received: from wsh by steelpick.localdomain with local (Exim 4.71) (envelope-from ) id 1Npl9l-0008Al-IX; Thu, 11 Mar 2010 17:22:41 +0100 From: Michal Sojka To: James Vasile , notmuch@notmuchmail.org In-Reply-To: <87fx46hq7w.fsf@hackervisions.org> References: <87aauhp9kk.fsf@hackervisions.org> <87pr3bm2sn.fsf@steelpick.localdomain> <87fx46hq7w.fsf@hackervisions.org> Date: Thu, 11 Mar 2010 17:22:41 +0100 Message-ID: <87ljdyn7zi.fsf@steelpick.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [PATCH] Change From and Bcc when creating reply draft buffer X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2010 16:22:58 -0000 On Thu, 11 Mar 2010, James Vasile wrote: > On Thu, 11 Mar 2010 14:00:08 +0100, Michal Sojka wrote: > > Hi James, > > > > On Tue, 09 Mar 2010, James Vasile wrote: > > > When notmuch creates a reply buffer, it guesses the From and Bcc > > > addresses. The client is in a better position to guess these, and this > > > patch adjusts notmuch-reply accordingly. > > > > > > diff --git a/notmuch.el b/notmuch.el > > > index ab56f48..07f957e 100644 > > > --- a/notmuch.el > > > +++ b/notmuch.el > > > @@ -436,10 +436,20 @@ buffer." > > > (message "Done")) > > > > > > (defun notmuch-reply (query-string) > > > + "Prepare a reply draft buffer. > > > + > > > +Have notmuch create a reply buffer, then adjust the from and bcc > > > +headers to match our current user-full-name and > > > +user-mail-address." > > > (switch-to-buffer (generate-new-buffer "notmuch-draft")) > > > (call-process notmuch-command nil t nil "reply" query-string) > > > (message-insert-signature) > > > (goto-char (point-min)) > > > + (kill-line) > > > + (insert (format "From: %s <%s>" user-full-name user-mail-address)) > > > > Notmuch reply contains From: address which is based on the addresses in > > .notmuch-config and the replied message. When you use multiple addresses > > (e.g. home and work address), notmuch puts there the one used in the > > replied message. It seems that your patch would break this feature. > > > > -Michal > > Yes, it does break that feature, and intentionally so. The MUA should > select the From: address. I have profile selection code that sets my > user-full-name and user-mail-address based on some context. When I > reply to somebody, the correct From: address is not who they think I am > but rather who *I* think I am. > > Here's my use case: I have a job in the free software world. There's an > email address attached to that. I also serve on the board of a free > software project. There's another email for that. People email me > about the project using my work email, but I always reply using the > project email, and my MUA knows that. Notmuch doesn't. > > Also: my girlfriend's family sometimes emails me at work. I don't want > personal email at my work address, so I always reply using a personal > address. > > Also: I have an old email address that I've deprecated, but old friends > still use it. I always reply with my newer address and they eventually > start using the new one. > > My profile code is usable but not complete. It looks at folder contents > to pick the correct From: address automatically (you can override the > choice, of course), which is good when you have 400+ folders. If > anybody wants it before it's done, I can put it in a public branch. Hi, thanks for clarification. It all sounds reasonable. The only problem I can see now is that if I create a new account on my machine and run emacs there, then the value of user-mail-address is @ which doesn't refer to existing mailbox. I think that the header should only be rewritten if these variables are known to have valid values. Do you know how to do this? -Michal