From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Bhaskara Marthi <bhaskara@gmail.com>,
notmuch@notmuchmail.org, cworth@cworth.org
Subject: [PATCH] Fix compilation when getline is not available
Date: Mon, 29 Mar 2010 10:43:10 +0200 [thread overview]
Message-ID: <87ljdbh61t.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <330356ae1003282354s639a0ff5p34a6a29bbe145ed5@mail.gmail.com>
On Mon, 29 Mar 2010, Bhaskara Marthi wrote:
> Hi all, I'm trying to build notmuch on os x (master branch from today). I
> got the ports for gmime and xapian, and installed talloc from source, with
> some minor hitches (just getting talloc alone from samba failed on autoconf
> due to lack of libreplace.m4, so I installed all of samba from a port; a
> pkg-config file for talloc was not put in the right place after that,
> though, so I had to make one).
>
> Anyway, now compilation runs into the following error. Looks like an issue
> with the makefile given that getline is in fact defined in compat/. How
> should I fix this?
The following patch should fix it.
---
Makefile | 2 +-
compat/Makefile.local | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 46f001c..93c6b2b 100644
--- a/Makefile
+++ b/Makefile
@@ -46,7 +46,7 @@ subdirs = compat emacs lib
global_deps = Makefile Makefile.config Makefile.local \
$(subdirs:%=%/Makefile) $(subdirs:%=%/Makefile.local)
-include Makefile.config Makefile.local $(subdirs:%=%/Makefile.local)
+include Makefile.config $(subdirs:%=%/Makefile.local) Makefile.local
# The user has not set any verbosity, default to quiet mode and inform the
# user how to enable verbose compiles.
diff --git a/compat/Makefile.local b/compat/Makefile.local
index 17b4514..9f84c5f 100644
--- a/compat/Makefile.local
+++ b/compat/Makefile.local
@@ -1,7 +1,7 @@
dir := compat
extra_cflags += -I$(dir)
-notmuch_compat_srcs =
+notmuch_compat_srcs :=
ifneq ($(HAVE_GETLINE),1)
notmuch_compat_srcs += $(dir)/getline.c $(dir)/getdelim.c
--
1.7.0.2
next prev parent reply other threads:[~2010-03-29 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 6:54 os x getline issues Bhaskara Marthi
2010-03-29 8:43 ` Michal Sojka [this message]
2010-03-29 16:43 ` [PATCH] Fix compilation when getline is not available Bhaskara Marthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljdbh61t.fsf@steelpick.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=bhaskara@gmail.com \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).