Re: [PATCH 3/4] Add infrastructure for building shared library on OS X.

[Carl Worth <cworth@cworth.org>]

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On Wed, 14 Apr 2010 11:01:58 -0700, Carl Worth <cworth@cworth.org> wrote:
> > +printf "Checking for Mac OS X (for shared library)... "
> > +if [ `uname` = "Darwin" ] ; then
> > +    printf "Yes.\n"
> > +    mac_os_x=1
> > +else
> > +    printf "No.\n"
> > +    mac_os_x=0
> > +fi
> > +
> 
> Instead of inventing a new mac_os_x variable, we should follow the GNU
> configure conventions of build_cpu, build_vendor, build_os
> variables.

I've gone ahead and pushed the above. We can still fix to use build_os
internally instead of mac_os_x, but that's fairly cosmetic.

I also pushed out my own version of the fix for FINAL_NOTMUCH_LDFLAGS,
(which does the extra linking on OS X, but not Linux).

Please, anyone that's interested, test notmuch on your favorite
platforms and let us know what's still broken. I did do a little testing
and research with the OS X machine I could find here, but I'm no expert,
nor do I have access to many other systems.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]