From: Carl Worth <cworth@cworth.org>
To: Jesse Rosenthal <jrosenthal@jhu.edu>,
Sebastian Spaeth <Sebastian@SSpaeth.de>,
Notmuch development list <notmuch@notmuchmail.org>
Subject: Re: sort order regression
Date: Thu, 22 Apr 2010 14:10:48 -0700 [thread overview]
Message-ID: <87ljcfqjl3.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <87tyr37e4p.fsf@jhu.edu>
[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]
On Thu, 22 Apr 2010 16:06:27 +0200, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
>
> jkr and I noticed that patch series are shown in reverse order now, in
> fact threads seem to display messages at the same depth in reverse
> chronological order now.
My fault! Sorry about that.
On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> Just to follow up on this, it seems that the regression comes from the
> fix Carl introduced in 2a1a4f0551 to make his simplification of my patch
Indeed that was the problem. And your original code *did* pass the tests
I wrote. There are still a couple of cleanups I'd like to make, (like
assigning the subject only in _add_matched_message and not uselessly in
_add_message as well). But I can do those now without breaking the test
suite!
> Unfortunately, I'm not quite skilled enough at git to turn back some
> files to a certain state, tests to another state, and so on.
For now, since the test suite is just a single file, it's easy enough to
do:
cp test/notmuch-test latest-notmuch-test
git checkout HEAD~5 # or whatever
make
./latest-notmuch-test
Though that doesn't answer the question of how to do this with
git. Probably something like:
git checkout HEAD~5
git checkout master -- test
make test
On Thu, 22 Apr 2010 10:31:18 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> Sorry, got that slightly wrong. The following commits need to be
> reverted:
>
> 36e4459a328b8449b3e9d510be81a332a9b35aaa
> f43990ce134d838cdb2cdd5d0752a602e81cfdd9
> 7fb56f9dc5d8e66f717f5e48ecbfbc11c8190182
>
> When I do this, search order is right, and all tests are passed.
I did this. And before doing it I added a new test to show the
regression, (which the reverts then make pass).
So in my defense, it wasn't my fault[*] I didn't notice the
regression. It was the test suite's fault for not testing "notmuch show"
at all.
-Carl
[*] Except that I'm the one that wrote the test suite and didn't put any
"notmuch show" tests into it. Oops!
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-04-22 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 14:06 sort order regression Sebastian Spaeth
2010-04-22 14:14 ` Jesse Rosenthal
2010-04-22 14:21 ` Jesse Rosenthal
2010-04-22 14:31 ` Jesse Rosenthal
2010-04-22 21:10 ` Carl Worth [this message]
2010-04-23 7:28 ` Sebastian Spaeth
2010-04-23 8:15 ` Michal Sojka
2010-04-23 15:18 ` Carl Worth
2010-04-26 9:59 ` Michal Sojka
2010-04-26 15:05 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljcfqjl3.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=Sebastian@SSpaeth.de \
--cc=jrosenthal@jhu.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).