Re: [PATCH 2/2] emacs: notmuch-hello: Add "n" and "p" to mod map

[Pieter Praet <pieter@praet.org>]

On Tue, 27 Jul 2010 09:48:45 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> Bind "n" to widget-forward and "p" to widget-backward to unify the
> interface since other notmuch major mode also accept "n" and "p" to
> navigation.
> ---
>  emacs/notmuch-hello.el |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 6ef03bb..7def241 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -294,6 +294,8 @@ should be. Returns a cons cell `(tags-per-line width)'."
>      (define-key map "=" 'notmuch-hello-update)
>      (define-key map "G" 'notmuch-hello-poll-and-update)
>      (define-key map (kbd "<C-tab>") 'widget-backward)
> +    (define-key map "n" 'widget-forward)
> +    (define-key map "p" 'widget-backward)
>      (define-key map "m" 'notmuch-mua-mail)
>      (define-key map "s" 'notmuch-hello-goto-search)
>      map)
> -- 
> 1.7.1
> 
> 


Sounds logical in theory, but in practice, you'll soon get stuck
spamming "nnnnnpppnwtf" in the search field.

That, and TAB/S-TAB feels more natural.

Thanks to this patch, however, I did stumble upon a bug:
id:"87ei522v4t.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me"

Peace

-Pieter